Skip to content

0.9#148

Merged
MizunagiKB merged 23 commits intomainfrom
0.9
Mar 26, 2025
Merged

0.9#148
MizunagiKB merged 23 commits intomainfrom
0.9

Conversation

@MizunagiKB
Copy link
Copy Markdown
Owner

This is a pull request to merge 0.9 into main.

@MizunagiKB MizunagiKB merged commit 1487327 into main Mar 26, 2025
@erodozer
Copy link
Copy Markdown
Contributor

it looks like v0.9.0 was tagged before the latest commit in this merge. Will v0.9.1 be tagged shortly after with the bug fixes and performance improvements?

@MizunagiKB
Copy link
Copy Markdown
Owner Author

MizunagiKB commented Mar 26, 2025

You may have been wondering why the following two were not included in tag v0.9.0:

I understand this may have caused some confusion, but these issues were identified after the release. As a result, they came after the tag v0.9.0.

This time, the process went as follows:

  1. Work on branch 0.9.
  2. Create tag v0.9.0 and release.
  3. Immediately after the release, add new pull requests to branch 0.9.

This likely caused questions, such as, "So, where should I branch or submit my pull requests?" especially for contributors other than myself.

I believe this situation arose because I have not established clear rules for the release cycle.

For tag v0.9.1, I have made the situation clearer by creating the following pull request. If you find any bugs to fix, please submit pull requests to the branch 0.9.


Regarding a larger concern, it may be this:

As this involves significant changes, I believe it would be better to create a new branch 0.10.

It would be best to discuss this further, but it appears that this change will significantly impact both GDCubismUserModel and InternalCubismUserModel.

While I was considering either switching or adding functionality, I believe we could separate the current implementation (which fully depends on the existing Live2D CubismNativeFramework) as a reference implementation, such as renaming it to GDCubismUserModelNF, NFCubismUserModel.

NF ... NativeFramework

Although this would mean maintaining both implementations, I don’t believe this would require more work than keeping up with CubismNativeFramework build support.

@erodozer
Copy link
Copy Markdown
Contributor

I was more concerned that because the tag and release occurred before this PR had merged, these two fixes weren't included even though they're present here

#146
#147

@MizunagiKB
Copy link
Copy Markdown
Owner Author

I sincerely apologize for the inconvenience caused.
Let us release the currently committed version as 0.9.1, and prepare version 0.9.2 separately.

@MizunagiKB MizunagiKB mentioned this pull request Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants