Conversation
…andling as well as try/except and logging
Closed
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
MmelIGaba
requested changes
Nov 7, 2025
Owner
MmelIGaba
left a comment
MmelIGaba
left a comment
There was a problem hiding this comment.
Great work so far:
- Excellent use of os.makedirs(..., exist_ok=True) for directory safety.
- Logging is correctly set up with timestamps and severity levels.
- Clear messaging when CSV files are missing.
- Good separation of logic into a function (ensure_raw_csv_exists).
- Kaggle dataset link is helpful for users to recover missing data.
Recommendations:
Fix python lint test:
Run flake8 Back-End/etl/
Back-End/etl/extract.py:21:1: E302 expected 2 blank lines, found 1
Back-End/etl/extract.py:43:1: E305 expected 2 blank lines after class or function definition, found 1
Error: Process completed with exit code 1.
Please mention that this closes issue #6
MmelIGaba
approved these changes
Nov 7, 2025
Owner
MmelIGaba
left a comment
MmelIGaba
left a comment
There was a problem hiding this comment.
Time pressed, merging. We will worry about linting in future PRs. Will try to fix this in my next push. Great job so far.
Owner
|
Closes #6 |
MmelIGaba
deleted the
feature/6-scaffold-extractpy-to-download-kaggle-dataset
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.