Verify that input metric has strictly positive eigenvalues#320
Open
corentin-prigent wants to merge 6 commits intoMmgTools:developfrom
Open
Verify that input metric has strictly positive eigenvalues#320corentin-prigent wants to merge 6 commits intoMmgTools:developfrom
corentin-prigent wants to merge 6 commits intoMmgTools:developfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #320 +/- ##
===========================================
- Coverage 50.30% 50.27% -0.03%
===========================================
Files 177 177
Lines 47857 47892 +35
Branches 10355 10376 +21
===========================================
+ Hits 24075 24079 +4
- Misses 16050 16060 +10
- Partials 7732 7753 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
taupalosaurus
requested changes
Feb 11, 2026
Contributor
taupalosaurus
left a comment
taupalosaurus
left a comment
There was a problem hiding this comment.
Can you please:
- get rid of pointer arithmetic
- factorize the changes ?
| if ( sol->size == 3 ) { | ||
| for (k=1; k<=sol->np; k++) { | ||
| double lambda[2],vp[2][2]; | ||
| MMG5_eigensym(sol->m+3*k,lambda,vp); |
Contributor
There was a problem hiding this comment.
Suggested change
| MMG5_eigensym(sol->m+3*k,lambda,vp); | |
| MMG5_eigensym(&sol->m[3*k],lambda,vp); |
|
|
||
| /* For anisotropic metric, check that eigenvalues are stricly positive*/ | ||
| for ( j=0; j<nsols; j++ ) { | ||
| psl = *sol+j; |
Contributor
There was a problem hiding this comment.
Suggested change
| psl = *sol+j; | |
| psl = &all_sols[j]; |
Contributor
There was a problem hiding this comment.
where
MMG5_Sol *all_sols;
all_sols = *sol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update adds a computation of input metric eigenvalues after loading it to verify that they are strictly positive. If not, exit the code.
This is done for mmg3d, mmg2d and mmgs, for both versions of the API functions:
MMG[3D/2D/S]_loadSol()and
MMG[3D/2D/S]_loadAllSols()Tests have been made to ensure validity of the checks.