fix(api): allow null raw message before review approval#478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correct the shared message-detail contract for outbound review drafts:
raw_messageremains required but is nullable until approval composes canonical MIME. Regenerate both SDK models and add server/SDK regressions for the lifecycle.Client surface checklist
make generate-sdk-checkis clean)No migration, CLI, or MCP behavior changes are required: storage already intentionally keeps review drafts in
body_text/body_html, and all clients consume the shared generated message model.Operational risk
Contract-only correction. No delivery, persistence, billing, authentication, or notification behavior changes. Generated clients now accept the value the server already emits.
Test plan
go test ./internal/httpapi -count=1make spec-checkmake generate-sdk-checknpm run build --workspace @e2a/sdknpm test --workspace @e2a/sdk— 155 passedsdks/python/.venv/bin/pytest sdks/python/tests/ -q— 277 passed, 18 skipped