feat: move split-view pane controls into title-bar tabs#676
Merged
Conversation
Pane titles, maximize, and close move out of per-pane mosaic toolbars into a new SplitTabs component pinned in the title bar. Maximize and focus state are lifted into uiStore (maximizedTile / focusedTile) so the tab highlight and the CSS maximize stay in sync, and reset together with activeAgentTile whenever the active chat changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SplitTabscomponent pinned in the title bar; the mosaic toolbar now renders empty.uiStoreasmaximizedTile/focusedTile, with a singlefocusTileaction that also coarsens toactiveAgentTile(primary vs secondary chat).maximizedTileat the canonicalremoveTileFromMosaicevent so a re-added tile id can't resurrect a stale maximize.SplitTabsis self-sourcing, soagentTitles/onCloseTileprops are dropped fromSplitViewContainerandMosaicSplitView.Test plan