Deduplicate skills by resolved path and handle symlinks#681
Merged
Conversation
Skills can be symlinked across agent namespaces to a single canonical directory. List operations now group by resolved path and track all sources that point to the same skill. The skill dict schema changes from 'source' (singular) to 'sources' (list) to reflect this. When updating a symlinked skill, resolve the target directory before rmtree — symlinks don't expand to directories under rmtree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
source(string) tosources(list of strings)Why
Skills can be symlinked across multiple agent namespaces to point to the same
canonical directory. Previously, the same skill would appear multiple times in
the list. Now, deduplication happens by resolved path, and we track which
namespaces source each skill.