refactor: centralize view icons and update tab indicator#683
Merged
Conversation
Extract VIEW_ICONS mapping to tileHelpers for shared use across pane tabs and view switcher. Update split tabs UI to display icons with bottom underline indicator instead of background color, and remove the kind label from tab text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VIEW_ICONSmapping intileHelpers.tsChanges
tileHelpers.ts: AddVIEW_ICONSrecord mapping view types to Lucide iconsSplitTabs.tsx: Display icon for each tab, add underline indicator for active tab, remove kind labelViewSwitcher.tsx: Simplify to use centralizedVIEW_ICONSinstead of inline icon definitions