fix: fixed rendering sensitive inputs#55
Merged
Merged
Conversation
ssmrmmk
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes sensitive-field rendering in the default form renderer of @mobile-reality/mdma-renderer-react. Fields marked sensitive: true were rendering their values in plaintext while the user typed, only masking pre-filled values — the opposite of the intended behavior. Two accompanying CSS defects made it worse: masked inputs switch to type="password", which had no matching style rule and collapsed to an unstyled native box, and the reveal/mask toggle button wrapped onto its own line below the input instead of sitting inside it.
The bug lived entirely in the shipped default component (not the ag-ui integration example, which just consumes it with no overrides), so it affected every consumer using the default form renderer for sensitive fields.
Type of Change
Packages Affected
@mobile-reality/mdma-spec@mobile-reality/mdma-parser@mobile-reality/mdma-runtime@mobile-reality/mdma-attachables-core@mobile-reality/mdma-renderer-react@mobile-reality/mdma-prompt-packChecklist
pnpm formatandpnpm lintpass).pnpm test).pnpm typecheck).pnpm changeset) if this change affects published packages.sensitive: truewhere appropriate.Screenshots / Examples
Before: typing into a sensitive field showed plaintext (asdasda), and the mask toggle rendered below the input; masked state collapsed the input to a narrow native box.
After: sensitive fields mask from the first keystroke (•••), with the 👁/🔒 toggle overlaid inside a full-width input.