Include Android app name in handshake metadata#387
Open
samsamtrum wants to merge 1 commit into
Open
Conversation
sara554-beep
approved these changes
Jun 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the Android app label to the handshake payload so wallets can display a recognizable dapp name instead of relying only on the package id.
Problem
RequestContent.Handshakealready supports optionalappName, but the Android native SDK never populated it. As a result, wallet confirmation/connection surfaces can receive only the package identifier (appId), which is less readable for end users and can be inconsistent with the iOS/JS-facing expectation that apps may provide display metadata.Changes
Context.applicationInfo/PackageManager.appNamewhen building the Android handshake message.appNameas an optional parameter with the app label as the default, so callers can still override or omit it.Verification
git diff --checkpasses.JAVA_HOME=/usr/lib/jvm/java-17-openjdk-amd64 ./gradlew :walletsdk:compileDebugKotlin :walletsdk:testDebugUnitTest --stacktraceANDROID_HOME, so Gradle cannot resolve the Android SDK location before compiling. No project test failures were reached.