Refresh tnumber ln/exp/log expected output for MEOS turning points#138
Closed
estebanzimanyi wants to merge 1 commit into
Closed
Refresh tnumber ln/exp/log expected output for MEOS turning points#138estebanzimanyi wants to merge 1 commit into
estebanzimanyi wants to merge 1 commit into
Conversation
This was referenced May 16, 2026
Member
Author
Reviewer's quickstart — ~2 minutesWhat this PR does: Refresh tnumber ln/exp/log expected output for MEOS turning points. Files to read: Risk: narrow scope; the diff is small and self-contained. Stacked on its base PR — once the stack ahead of it lands, this rebases trivially. Cross-link: Linux arm64 CI needs #161 for the |
…pected The tfloat ln/exp/log10 lifts insert one chord-error turning point on a linear segment; the MEOS pin computes it in double so the inserted instant is identical on every platform, and the 026b expected carries the three-instant result.
estebanzimanyi
force-pushed
the
fix/tnumber-math-turnpt-expected
branch
from
42b75df to
a465ddd
Compare
estebanzimanyi
force-pushed
the
fix/meos-per-thread-init
branch
from
6900085 to
7b85d06
Compare
Member
Author
|
Folded into #134: the MEOS pin bump and the changes that keep CI green (graceful icu degradation + stage_icu, per-thread MEOS init, deterministic ln/exp/log10, macOS int64 forwarder, wasm pg_config) are jointly required for the extension to build, load, and pass — they ship as one foundation PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MEOS uplift adds tfloat_ln_turnpt / tfloat_exp_turnpt (MobilityDB #1003), which insert one chord-error-minimising turning point on a linear input segment for the transcendental unary lifts, so ln/log10/exp over a two-instant tfloat now return three instants. This refreshes the 026b expectations to the new values (captured from the built extension); deltaValue, trend and the arithmetic-alias cases are linear and unchanged. With this on top of the per-thread MEOS init fix the amd64 suite is fully green (59/59 files locally and the previously failing assertion now passes).