Skip to content

Wrap bigint_to_set in an int64_t forwarder for SetUnionAgg #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
estebanzimanyi wants to merge 1 commit into from
Closed

Wrap bigint_to_set in an int64_t forwarder for SetUnionAgg #140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/temporal/set.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -945,6 +945,13 @@ static inline Set *date_to_set_duckdb(DateADT d) {
return date_to_set(ToMeosDate(duckdb::date_t(d)));
}

// macOS LP64: int64 (long) and int64_t (long long) are distinct types, so
// clang rejects passing bigint_to_set where a Set *(*)(int64_t) is expected as
// a non-type template arg. The cast is a no-op on Linux.
static inline Set *bigint_to_set_duckdb(int64_t i) {
return bigint_to_set(static_cast<int64>(i));
}

struct SetPtrState {
Set *accumulated;
};
Expand Down Expand Up @@ -1069,7 +1076,7 @@ void SetTypes::RegisterSetUnionAgg(ExtensionLoader &loader) {
LogicalType::INTEGER, SetTypes::intset()));
set_union_set.AddFunction(
AggregateFunction::UnaryAggregateDestructor<SetPtrState, int64_t, string_t,
SetUnionScalarFunction<int64_t, bigint_to_set>>(
SetUnionScalarFunction<int64_t, bigint_to_set_duckdb>>(
LogicalType::BIGINT, SetTypes::bigintset()));
set_union_set.AddFunction(
AggregateFunction::UnaryAggregateDestructor<SetPtrState, double, string_t,
Expand Down
Loading