Build the pinned MEOS with the CBUFFER, NPOINT, POSE and RGEO modules#145
Open
estebanzimanyi wants to merge 1 commit into
Open
Build the pinned MEOS with the CBUFFER, NPOINT, POSE and RGEO modules#145estebanzimanyi wants to merge 1 commit into
estebanzimanyi wants to merge 1 commit into
Conversation
This was referenced May 17, 2026
Member
Author
Reviewer's quickstart — ~2 minutesWhat this PR does in one sentence: flips the MEOS build flags in Files (1): Unlocks: the Cross-link: stacked on #134 (the base pin bump). Once #134 lands, this rebases on main and the *_port_core PRs can adopt this MEOS. Why it's safe to merge: pure build-flag change; doesn't alter source code. |
This was referenced May 20, 2026
estebanzimanyi
added a commit
to estebanzimanyi/MobilityDuck
that referenced
this pull request
May 25, 2026
Enable the opt-in MEOS modules required to port the extended temporal types (tcbuffer, tnpoint, tpose, trgeometry) into MobilityDuck. RGEO is a dependent option that requires POSE. The pinned MEOS now exposes the tcbuffer_/tnpoint_/tpose_/trgeo_ symbol families; the base type suite remains green (1727 assertions, 76 cases). Folds open PR MobilityDB#145.
8cd82d4 to
baa3d09
Compare
b591405 to
4beb327
Compare
1ac9cc5 to
204ac54
Compare
fa2de57 to
17588c0
Compare
204ac54 to
bd60aa4
Compare
bd60aa4 to
10be1d0
Compare
a33f008 to
ec582fe
Compare
10be1d0 to
5b24d8e
Compare
ec582fe to
f9e99dc
Compare
5b24d8e to
6ede112
Compare
f9e99dc to
20328a7
Compare
6ede112 to
aff2189
Compare
20328a7 to
6a4edaf
Compare
aff2189 to
a4a6ef0
Compare
6a4edaf to
dab415b
Compare
656919e to
88c6161
Compare
22d2966 to
db34f35
Compare
88c6161 to
9bf5ef8
Compare
(cherry picked from commit bd60aa4)
db34f35 to
a8d5194
Compare
9bf5ef8 to
458c711
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MobilityDuck extended temporal type ports (tcbuffer, tnpoint, tpose, trgeometry) cannot link until the vcpkg-built MEOS exposes those modules. MEOS builds them opt-in and RGEO is a dependent option that requires POSE, so all four are enabled together in the vcpkg portfile OPTIONS, leaving each subsequent type port as pure extension code. Stacked on #134 because main's pinned MEOS predates the symbols these modules need and #134 already advances the pin; #134's pin-bump commit shows in the diff until it merges. The OPTIONS edit is independent of the REPO/REF/SHA512 pin lines that #142 and #143 rewrite, so it composes with whichever pin lands and needs only ordering, not textual reconciliation, against those PRs.