Skip to content

chore: Bump action workflows to versions that use Node24#2166

Merged
jcpitre merged 15 commits into
MobilityData:masterfrom
cswilson252:node24
Jul 17, 2026
Merged

chore: Bump action workflows to versions that use Node24#2166
jcpitre merged 15 commits into
MobilityData:masterfrom
cswilson252:node24

Conversation

@cswilson252

Copy link
Copy Markdown
Contributor

Summary:

Bumps the actions under .github to versions that use Node 24, since this will become the default soon

Please make sure these boxes are checked before submitting your pull request - thanks!

@cswilson252
cswilson252 marked this pull request as draft May 26, 2026 17:41
@cswilson252
cswilson252 marked this pull request as ready for review June 16, 2026 22:50
@cswilson252

Copy link
Copy Markdown
Contributor Author

should be good here?

@jcpitre
jcpitre requested a review from davidgamez June 22, 2026 14:39
@davidgamez

Copy link
Copy Markdown
Member

Hi @cswilson252 , most bumps are correct, but few don't actually reach Node 24:

  • download-artifact@v6 → still node20. Needs @v7/@v8. (acceptance_test.yml, end_to_end.yml, notice_migration_generation.yml)
  • github-script@v6node16. Needs @v8. (package_installers.yml)
  • setup-node@v4node20. Needs @v5/@v6. The node-version: '24.x' input is unrelated to the action's own runtime. (create_issue_if_referencemd_changes.yml)

Other suggested changes:

  • setup-python@v4 left unbumped in notice_migration_generation.yml (node16); setup-node@v4 untouched in web_client_test.yml.

@cswilson252

Copy link
Copy Markdown
Contributor Author

Hi @cswilson252 , most bumps are correct, but few don't actually reach Node 24:

* **`download-artifact@v6`** → still **node20**. Needs `@v7`/`@v8`. (`acceptance_test.yml`, `end_to_end.yml`, `notice_migration_generation.yml`)

* **`github-script@v6`** → **node16**. Needs `@v8`. (`package_installers.yml`)

* **`setup-node@v4`** → **node20**. Needs `@v5`/`@v6`. The `node-version: '24.x'` input is unrelated to the action's own runtime. (`create_issue_if_referencemd_changes.yml`)

Other suggested changes:

* **`setup-python@v4`** left unbumped in `notice_migration_generation.yml` (node16); `setup-node@v4` untouched in `web_client_test.yml`.

ok, fixed these, thank you! :)

@davidgamez
davidgamez requested a review from jcpitre June 25, 2026 17:51
@jcpitre

jcpitre commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Apparently for actions/github-script@v8 they (indirectly) moved github.repos.* to github.rest.repos.*
See https://github.com/actions/github-script#v5

Accordingly this line should be changed: https://github.com/cswilson252/gtfs-validator/blob/39716ca5f26c14d97f87f393e381547bc60c87eb/.github/workflows/package_installers.yml#L208

@cswilson252

Copy link
Copy Markdown
Contributor Author

updated!

@jcpitre jcpitre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!
Thanks @cswilson252

@jcpitre
jcpitre merged commit 03717cb into MobilityData:master Jul 17, 2026
75 checks passed
@cswilson252
cswilson252 deleted the node24 branch July 18, 2026 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants