feat: introduce dual themes, make themes easier to apply#34
Open
MarkoSagadin wants to merge 1 commit intomainfrom
Open
feat: introduce dual themes, make themes easier to apply#34MarkoSagadin wants to merge 1 commit intomainfrom
MarkoSagadin wants to merge 1 commit intomainfrom
Conversation
Several CSS theme changes in these one: - frontend build system now generates dual (light/dark) themes that are easy to switch between in the Anki clients, by changing the theme preference settings. - The individual single color themes are still available for theme_builder purposes (theme inspection and development in the web browser). - Each theme now also contains the CSS code from themeless_main.css file. That way users can just copy-paste one of the CSS themes in themes folder and apply it directly in Anki. Previously, if someone did that, the theme would not get applied due to the missing themeless_main.cssj. - Selector :root.nightMode was changed to :root in all CSS files: the latter is the only one that works in both Anki and web browser. - Documentation was updated to reflect the updated state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several CSS theme changes in these one: