Skip to content

fix 2 positional arguments but 3 were given #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Qubitium merged 1 commit into from
Apr 28, 2026
Merged

fix 2 positional arguments but 3 were given #126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions evalution/engines/transformers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,7 +469,7 @@ def _processor_init_with_fa2_cb_graph_fix(self: Any, *args: Any, **kwargs: Any)
False,
):
@wraps(current_generation_step)
def _generation_step_with_fa2_cb_graph_fix(self: Any, model: Any) -> None:
def _generation_step_with_fa2_cb_graph_fix(self: Any, *args: Any, **kwargs: Any) -> None:
"""Implement generation step with fa2 cb graph fix for this module."""

original_use_cuda_graph = getattr(self, "use_cuda_graph", False)
Expand All @@ -479,7 +479,11 @@ def _generation_step_with_fa2_cb_graph_fix(self: Any, model: Any) -> None:
else self.use_cuda_graph_varlen
)
try:
current_generation_step(self, model)
# Keep compatibility across transformers versions where
# _generation_step signatures differ:
# - old: _generation_step(self, model, logit_processor)
# - new: _generation_step(self, model)
current_generation_step(self, *args, **kwargs)
finally:
self.use_cuda_graph = original_use_cuda_graph

Expand Down