🐛 Bugfix: Adapt frontend for k8s A2A port configuration#3271
Open
xuyaqist wants to merge 16 commits into
Open
Conversation
…f-verification" field
…ubernetes container. (#3254) [Specification Details] 1. Modify the pod naming logic to convert all non-compliant characters to -. 2. Modify test cases.
…of type 'FieldInfo' is not iterable (#3259)
…fter importing an agent. (#3258) [Specification Details] 1. The frontend does not pass `agent_id` when calling the `regenerate_name` API.
The default setting for client-side self-validation is "False".
66e5370 to
a49a9e6
Compare
JasonW404
reviewed
Jun 24, 2026
| cpu: 0.5 | ||
| limits: | ||
| memory: 4Gi | ||
| memory: 64Gi |
Member
There was a problem hiding this comment.
内存限制从 4Gi 直接提升到 64Gi(16 倍),这个幅度异常大。如果是为了应对特定场景的内存峰值,建议添加注释说明原因。如果是内存泄漏导致的 OOM,应该排查根因而不是单纯提高限制。
Contributor
🔍 Code Review Comments1. [代码规范] 默认端口处理 |
YehongPan
reviewed
Jun 24, 2026
YehongPan
left a comment
Contributor
There was a problem hiding this comment.
Code Review
- [代码规范] 应确认前端是否正确处理了
window.location.port为空(默认端口 80/443)的情况,避免拼接出host:这样的无效 URL。
Contributor
|
A2A over k8s is a solid architectural addition. The k8s-native approach (in-cluster service discovery, sidecar proxy) is well-chosen. Please ensure the fallback logic when the k8s environment is unavailable is tested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3267
