🐛 Bugfix: Fix i18n translation issues in navigation sidebar#3288
🐛 Bugfix: Fix i18n translation issues in navigation sidebar#3288xuyaqist wants to merge 16 commits into
Conversation
…f-verification" field
# Conflicts: # frontend/public/locales/zh/common.json
There was a problem hiding this comment.
Pull request overview
This PR updates the Chinese (zh) i18n strings for several navigation sidebar items to address reported translation issues in the sidebar.
Changes:
- Updated zh sidebar translations for Resource/Agent/MCP/Skill “Space” items to use “仓库” terminology.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "sidebar.resourceSpace": "资源仓库", | ||
| "sidebar.agentSpace": "Agent 仓库", | ||
| "sidebar.mcpSpace": "MCP 仓库", | ||
| "sidebar.skillSpace": "Skill 仓库", |
🔍 Code Review Comments1. [代码规范] i18n key 完整性确认 |
YehongPan
left a comment
There was a problem hiding this comment.
Code Review
- [代码规范] 应确认所有新增的 translation key 在
en和zhlocale 文件中都已补齐,避免 fallback 到 key 名称显示。建议添加 CI 检查自动检测缺失的 translation key。
| "sidebar.agentSpace": "Agent 空间", | ||
| "sidebar.mcpSpace": "MCP 空间", | ||
| "sidebar.skillSpace": "Skill 空间", | ||
| "sidebar.resourceSpace": "资源仓库", |
There was a problem hiding this comment.
将"空间"改为"仓库"是一个语义变更,不仅仅是翻译修正。"空间"(Space) 和"仓库"(Repository/Warehouse) 在用户认知上有区别——空间强调工作区域,仓库强调存储管理。请确认这个命名变更是否经过了产品/UX 团队的审核?另外需要确认英文 locale 文件中的对应翻译是否也需要同步更新。
| "sidebar.mcpSpace": "MCP 空间", | ||
| "sidebar.skillSpace": "Skill 空间", | ||
| "sidebar.resourceSpace": "资源仓库", | ||
| "sidebar.agentSpace": "Agent 仓库", |
There was a problem hiding this comment.
仅修改了中文 locale,但其他语言(如英文 en/common.json)中对应的 key 值是否也需要更新?如果英文仍然使用 "Space",会导致中英文 UI 语义不一致。
|
LGTM. The translation additions (Korean, Japanese, Indonesian, Malay) follow the existing pattern and locale conventions. No issues found. |
No description provided.