Skip to content

refactor(css): remove duplicated responsive and modal blocks in readmeforge.css#130

Open
Owais-Siddique-11 wants to merge 1 commit into
Mohit-368:mainfrom
Owais-Siddique-11:refactor/remove-duplicate-css-blocks
Open

refactor(css): remove duplicated responsive and modal blocks in readmeforge.css#130
Owais-Siddique-11 wants to merge 1 commit into
Mohit-368:mainfrom
Owais-Siddique-11:refactor/remove-duplicate-css-blocks

Conversation

@Owais-Siddique-11
Copy link
Copy Markdown

📋 Summary

Fixes #102

This PR removes duplicated CSS blocks from readmeforge.css to improve
maintainability and prevent future style inconsistencies. No UI/UX
changes
— purely a code cleanup.

🔍 What Was Duplicated

The following blocks appeared multiple times in the file:

Block Before After
@keyframes spin 1× ✅
@keyframes fadeIn 1× ✅
::-webkit-scrollbar styles 1× ✅
@media (max-width: 1024px) (responsive layout) 1× ✅
@media (max-width: 768px) (responsive layout) 1× ✅
.modal-overlay, .modal, .modal-header, .modal-body 1× ✅
.hero-content rule inside @media print 1× ✅
pre rule inside @media print 1× ✅

✅ Changes Made

  • Removed all duplicate responsive media queries
  • Consolidated modal styles into a single canonical block (kept the
    more complete version that includes .modal-footer)
  • Merged duplicate @keyframes declarations
  • Merged duplicate scrollbar styles
  • Cleaned up the @media print block (removed duplicate .hero-content
    and merged duplicate pre page-break rule)

🎯 Why This Matters

  • Easier maintenance — Future contributors only need to edit one
    location, not multiple
  • No risk of style drift — Eliminates the chance of one duplicate
    being updated while others are missed
  • Cleaner file — Significantly fewer lines while preserving every
    visual behavior
  • Better readability — Organized, predictable structure

🧪 Acceptance Criteria

  • Duplicate responsive blocks removed
  • Duplicate modal blocks removed
  • UI behavior unchanged in dark mode
  • UI behavior unchanged in light mode
  • Modal, preview panel, and print flow preserved
  • No broken layout on mobile breakpoints (1024px, 768px, 375px)

📝 Notes for Reviewer

This is a cleanup-only change — no redesign, no feature additions,
no class renames. The diff is intentionally a large deletion + small
reordering. All retained rules are byte-for-byte identical to one of
the original duplicates.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 17, 2026

Deploy Preview for makeareadme ready!

Name Link
🔨 Latest commit 5cdb50d
🔍 Latest deploy log https://app.netlify.com/projects/makeareadme/deploys/6a0974cbf0e37c00085581ba
😎 Deploy Preview https://deploy-preview-130--makeareadme.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant