refactor(css): remove duplicated responsive and modal blocks in readmeforge.css#130
Open
Owais-Siddique-11 wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for makeareadme ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Summary
Fixes #102
This PR removes duplicated CSS blocks from
readmeforge.cssto improvemaintainability and prevent future style inconsistencies. No UI/UX
changes — purely a code cleanup.
🔍 What Was Duplicated
The following blocks appeared multiple times in the file:
@keyframes spin@keyframes fadeIn::-webkit-scrollbarstyles@media (max-width: 1024px)(responsive layout)@media (max-width: 768px)(responsive layout).modal-overlay,.modal,.modal-header,.modal-body.hero-contentrule inside@media printprerule inside@media print✅ Changes Made
more complete version that includes
.modal-footer)@keyframesdeclarations@media printblock (removed duplicate.hero-contentand merged duplicate
prepage-break rule)🎯 Why This Matters
location, not multiple
being updated while others are missed
visual behavior
🧪 Acceptance Criteria
📝 Notes for Reviewer
This is a cleanup-only change — no redesign, no feature additions,
no class renames. The diff is intentionally a large deletion + small
reordering. All retained rules are byte-for-byte identical to one of
the original duplicates.