Improve resetAll function with safer checks and better UX#66
Open
Dhani213 wants to merge 1 commit into
Open
Conversation
Refactored the resetAll function to improve stability, safety, and user experience. Key improvements: - Added null/undefined checks to prevent runtime errors - Safely reset DOM elements and state variables - Improved handling of screenshots, badges, and tech selections - Added smooth scroll-to-top behavior after reset - Enhanced user feedback with clearer toast message - Ensured compatibility across different UI states This makes the reset functionality more robust and production-ready.
✅ Deploy Preview for makeareadme ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Owner
|
@Dhani213 sorry for being late but i have checked your code and found a bug that the reset button isnt working |
Author
|
Dear Sir,
I apologize for the inconvenience caused earlier regarding the Reset
functionality.I have now reviewed all fields, resetting sections to their
default state, and updating the live preview correctly.Kindly review the
changes at your convenience. Please let me know if any further improvements
are needed.
…On Sun, May 3, 2026 at 12:51 AM Mohit ***@***.***> wrote:
*Mohit-368* left a comment (Mohit-368/ReadmeForge#66)
<#66 (comment)>
@Dhani213 <https://github.com/Dhani213> sorry for being late but i have
checked your code and found a bug that the reset button isnt working
so fix it ASAP so that i can easily merge it
—
Reply to this email directly, view it on GitHub
<#66 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BXKRH7XDAQN6H7SPPABMSWL4YZDFDAVCNFSM6AAAAACYJS7GOSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DGNRUGU2DMNJSGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Owner
|
@Dhani213 i didn't see it working if you are facing any issue i am here to resolve it. But check it again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored the
resetAllfunction to improve stability, safety, and overall user experience.✨ Key Improvements
✅ Result
The reset functionality is now more robust, user-friendly, and production-ready.
Closes #3