BaseMapCodec.decode(): fix O(N²) complexity - #110
Open
nekotxs wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #88,
ImmutableMap.Builderwas replaced byObject2ObjectArrayMap. UsingputIfAbsent()on each element causes O(N²) complexity.I made some measurements and provided some context.
On pure vanilla it doesn't cause a lot of issues, but if you add some datapacks or mods with advancements, it can cause disastrous lags of up to several seconds on each player join, when advancements are loaded.
The easiest solution would be to replace
Object2ObjectArrayMapwithObject2ObjectOpenHashMap, though it can be less performant on N<=2.I suggest using
ImmutableMap.BuilderwithbuildOrThrow()as the default path, with a fallback toObject2ObjectOpenHashMapif any failures (including duplicate keys) are present. This makes sense since failures are rare in practice (I measured 0.004% of calls encountering a failure on a moderately modded server, and none on vanilla). This would give better performance than bothObject2ObjectArrayMapandObject2ObjectOpenHashMapin the common, failure-free case. The fallback path takes longer than plainObject2ObjectOpenHashMap, but it still has acceptable time and O(N) complexity.