Fix GoalOS public-site validation: standalone proof pages and AEP package allowlist#12
Fix GoalOS public-site validation: standalone proof pages and AEP package allowlist#12MontrealAI wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ccac283aea
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if any(term in name for term in PRIVATE_TERMS): | ||
| if suffix not in SAFE_PUBLIC_EXTENSIONS: | ||
| return True |
There was a problem hiding this comment.
Block paid/private directories, not just filenames
When a paid/private material is stored under a sensitive directory with a neutral basename, e.g. site/private/runbook.pdf or site/buyer_deliverables/receipt.pdf, both public-site validators pass it because this check scans only PurePosixPath(rel).name and ignores the rest of the relative path. That leaves non-ZIP buyer/private deliverables in public deploy roots undetected despite the new policy covering buyer-paid and private materials anywhere under site/ or public/; check the normalized full path or path parts instead of only the basename.
Useful? React with 👍 / 👎.
Motivation
Description
scripts/goalos_public_site_rules.pywith functions for path normalization,is_public_aep_package,is_standalone_proof_page,is_app_page,requires_canonical_shell, andis_blocked_paid_or_private_artifactso all validators share the same rules.scripts/validate_goalos_public_site.py,scripts/check_no_paid_artifacts.py,scripts/validate_docs_tables_figures.py, andscripts/validate_goalos_catalog.pythat import the shared rules and produce clearer, actionable error messages.site/rsi-ai-first-blockchain-capital-machine-proof.html,site/rsi-ai-first-governance-capital-engine-proof.html) to mark them as standalone proofs (<!-- GOALOS-STANDALONE-PROOF -->+<meta name="goalos-page-type" content="standalone-proof">), add a visible/proof-gradient/backlink and QUEBEC.AI identity, and ensure required title/description metadata.tests/test_goalos_public_site_rules.pyfor AEP allowlist, blocked buyer ZIPs, standalone-proof detection, app-page detection, safe assets, and canonical-shell requirements..github/workflows/validate-goalos-public-site-v12.yml,check-no-paid-artifacts.yml,validate-docs-tables-figures.yml,goalos-public-site-release-v12.yml, and updated legacy workflows to delegate to the new v12 flow.docs/GOALOS_PUBLIC_SITE_VALIDATION.md,docs/GOALOS_PAID_ARTIFACT_POLICY.md, and updateddocs/GOALOS_REPO_AUDIT.mdandREADME.mdnotes.Testing
python scripts/validate_goalos_public_site.pyand it passed for the repository public root (no canonical-shell false positives after classification changes).python scripts/check_no_paid_artifacts.pyand it passed while allowingstandards/AEP-001/complete-package.zipand similarstandards/AEP-###/complete-package.zippaths.python scripts/validate_docs_tables_figures.pyandpython scripts/validate_goalos_catalog.pyand both passed.pytest tests/test_goalos_public_site_rules.pyand all tests passed.Codex Task