Refresh GoalOS / Proof Gradient README, docs, figures, tables, badges, and validation#17
Refresh GoalOS / Proof Gradient README, docs, figures, tables, badges, and validation#17MontrealAI wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d6122fdaa0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| add_error(errors, rel, "is classified as standalone_proof_page but lacks a GoalOS / Proof Gradient link back", "add <a href=\"/proof-gradient/\">QUEBEC.AI ⚜️✨ · GoalOS · Proof Gradient</a>") | ||
| if not has_quebec_ai_visible_brand(text): | ||
| if explicit_standalone and not has_goalos_or_proof_gradient_escape(text): | ||
| add_error(errors, rel, "is classified as standalone_proof_page but lacks a GoalOS / Proof Gradient link back", "add <a href="/proof-gradient/">QUEBEC.AI ⚜️✨ · GoalOS · Proof Gradient</a>") |
There was a problem hiding this comment.
Escape the proof-gradient suggestion string
For explicit standalone proof pages that have GOALOS-STANDALONE-PROOF metadata but forget the GoalOS/Proof Gradient link-back, this line is evaluated while building the error message. Because the embedded href="/proof-gradient/" quotes are not escaped, Python parses it as string division using undefined names (proof, gradient), so the validator raises NameError instead of reporting the missing link and can make the public-site CI crash on the first such page.
Useful? React with 👍 / 👎.
| if importlib.util.find_spec('pytest') is None: | ||
| print('pytest unavailable; skipping optional paid-artifact regression tests') | ||
| sys.exit(0) |
There was a problem hiding this comment.
Keep the paid-artifact regression tests required
In this GitHub Actions job, no step installs the repo's dev dependencies before checking find_spec('pytest'), and pytest is only declared under optional dev dependencies in pyproject.toml. On a clean setup-python runner this branch exits 0, so the newly extended tests/test_goalos_public_site_rules.py regression coverage is silently skipped and future changes to the paid/private artifact classifier will not be caught by this workflow.
Useful? React with 👍 / 👎.
Motivation
Description
README.mdinto an institutional front page with the identity line, core thesis, safe AI boundary, the core loop, a bilingual product ladder table, and a top-row of static SVG badges.docs/data/goalos_catalog.ymlas the canonical catalog plus a humandocs/GOALOS_DOCUMENTATION_INDEX.mdand operational GoalOS docs (Proof Card 001 plan, paid-artifact policy, validation hotfix v14, Cloud MVP 0.2, catalog audit, roadmap, Web3 architecture, professional-firm summaries, etc.).docs/figures/*.mmdand committed SVG exports,docs/tables/*.csvCSV sources, static badge SVGs inbadges/, and updateREPO_FILE_TREE.txtandrepository_manifest.json.scripts/validate_docs_tables_figures.py,scripts/validate_goalos_catalog.py, smallscripts/validate_goalos_public_site.pyadjustments for v14 compatibility, extendtests/test_goalos_public_site_rules.py, and add/update GitHub Actions workflows (validate-docs-tables-figures.yml,check-no-paid-artifacts.yml,validate-goalos-catalog.yml).Testing
python scripts/check_no_paid_artifacts.py— passed.python scripts/validate_goalos_public_site.py— passed (v14 compatibility logic active).python scripts/validate_docs_tables_figures.pyandpython scripts/validate_goalos_catalog.py— both passed.pytest(after installing declared dev deps viapython -m pip install -e '.[dev]') andmake test, and the Cloud MVP Node testnode site/app/goalos-cloud-mvp/tests/enterprise-core.test.mjs— all passed.Codex Task