Refresh GoalOS / Proof Gradient README, docs, figures, tables, badges, and validation#19
Refresh GoalOS / Proof Gradient README, docs, figures, tables, badges, and validation#19MontrealAI wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0bfdaf322d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1,4 +1,4 @@ | |||
| name: GoalOS Public Site Release (v8-intelligent-assets, obsolete compatibility validation) | |||
| name: GoalOS Public Site Release v8 Intelligent Assets | |||
There was a problem hiding this comment.
Keep the release workflow from pretending to deploy
With this rename, the workflow is presented in Actions as the current v8 public-site release path, but inspected this same YAML: it has only contents: read, a validate-only job, and no Pages configure/upload/deploy step. When someone dispatches it expecting the documented v8 release, it will succeed after validation while leaving the public site unchanged.
Useful? React with 👍 / 👎.
| for label, body in (("README", readme), ("documentation", corpus)): | ||
| if price not in body or version not in body: | ||
| errors.append(f"{label} missing current price/version for {name}: {price} {version}") |
There was a problem hiding this comment.
Require product names in README/catalog drift checks
In the README/documentation branch of this product check, the product name is never tested, so deleting or renaming GoalOS RSI Lite in the README still passes as long as $199 and v1.6 appear anywhere else in the file. That leaves the new catalog validation unable to catch the exact product-ladder drift it reports in the error message.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2359d5629d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - name: Check paid/private artifact boundary | ||
| run: python scripts/check_no_paid_artifacts.py | ||
| - name: Validate public site classification and shell rules | ||
| run: python scripts/validate_goalos_public_site.py |
There was a problem hiding this comment.
Keep the Cloud MVP proof test in PR validation
When this PR workflow runs for changes under site/app/goalos-cloud-mvp/**, it now stops after the Python public-site validator. I checked scripts/validate_goalos_public_site.py, and app_page files are only checked for a <title>, while the remaining enterprise-core.test.mjs invocations are in workflow-dispatch/deploy-oriented workflows rather than this PR path; a change that breaks the Cloud MVP proof engine can therefore pass the current validation. Please keep the Node proof test, or an equivalent, in a PR-triggered workflow before accepting app changes.
Useful? React with 👍 / 👎.
Motivation
Description
README.md) that includes a truthful badge row, thesis lines, safe boundary, product ladder, shop routing, and validation/website guidance.docs/data/goalos_catalog.ymlcontaining project identity, product ladder, versions/prices, AEP list, validation & release status, approved/prohibited claims, and inventories.docs/anddocs/data/, created Mermaid sources and committed SVG exports for required figures indocs/figures/, added CSV tables indocs/tables/, and added static SVG badges underbadges/.scripts/validate_docs_tables_figures.py,scripts/validate_goalos_catalog.py, and keptscripts/check_no_paid_artifacts.pyandscripts/validate_goalos_public_site.py; centralized public-site rules inscripts/goalos_public_site_rules.py..github/workflows/validate-docs-tables-figures.yml,validate-goalos-catalog.yml,check-no-paid-artifacts.yml), and clearly marked obsolete validation workflows (v12/v13/old v8) so they are not presented as current.CONTRIBUTING.md,SECURITY.md,QA_VERIFICATION.md,ROADMAP.md,docs/GOALOS_PAID_ARTIFACT_POLICY.md,docs/GOALOS_VALIDATION_HOTFIX_V14.md, etc.) anddocs/GOALOS_REPO_AUDIT.mdcontaining the audit results and commands run.proof_gradientpackage, QUEBEC.AI assets, and public-site release automation; did not add any paid buyer deliverables to public roots.Testing
python scripts/check_no_paid_artifacts.py,python scripts/validate_goalos_public_site.py,python scripts/validate_docs_tables_figures.py, andpython scripts/validate_goalos_catalog.pyall passed after minor link/compatibility fixes.pytestexecuted (installed missinghttpxin the validation environment) and passed (85 passed, 3 warnings).make testpassed (unittest discovery run; all tests passed).node site/app/goalos-cloud-mvp/tests/enterprise-core.test.mjspassed and reported expected proof metrics.Commands used during verification:
python scripts/check_no_paid_artifacts.py,python scripts/validate_goalos_public_site.py,python scripts/validate_docs_tables_figures.py,python scripts/validate_goalos_catalog.py,pytest,make test, andnode site/app/goalos-cloud-mvp/tests/enterprise-core.test.mjs.Codex Task