Unify public-site validation and paid-artifact guard; add docs, badges, and workflows#20
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a5e08f4b96
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| for raw in re.findall(r"\(([^)]+)\)", body): | ||
| if is_blocked_paid_or_private_artifact(raw): | ||
| errors.append(f"{rel}: public paid/private artifact link {raw}") |
There was a problem hiding this comment.
Restrict paid-link scanning to actual Markdown links
This scans every parenthesized phrase in README/docs, not just links, so valid prose such as (private artifacts stay outside the public site) or (paid buyer products are excluded) is passed to is_blocked_paid_or_private_artifact and fails the catalog validator because terms like private, paid, or buyer are treated as blocked path tokens. Since this validator is now wired into PR workflows, ordinary documentation edits about the paid/private boundary can be blocked even when they add no public artifact link.
Useful? React with 👍 / 👎.
Motivation
Description
scripts/check_no_paid_artifacts.pyandscripts/validate_goalos_public_site.py), renamed job titles for clarity, and added a newvalidate-goalos-catalog.ymlworkflow.docs/(catalog, policies, product ladder, validation guidance, figures, and tables) and refreshedREADME.md,CONTRIBUTING.md,QA_VERIFICATION.md, andSECURITY.mdto reference the new validations and shop boundary.badges/andassets/, updatedREPO_FILE_TREE.txtandrepository_manifest.json, and introduced/expanded theproof_gradientpackage area in the tree.scripts/goalos_public_site_rules.pypatterns and unpacked/extendedscripts/validate_docs_tables_figures.py,scripts/validate_goalos_catalog.py, andscripts/validate_goalos_public_site.pyto validate docs, tables, figures, catalog consistency, AEP allowlist, and blocked paid/private artifacts.Testing
python scripts/check_no_paid_artifacts.pyandpython scripts/validate_goalos_public_site.py, and they passed in the validation environment.python scripts/validate_docs_tables_figures.pyandpython scripts/validate_goalos_catalog.py, which completed successfully.pytestandmake testand the Cloud MVP unit scriptnode site/app/goalos-cloud-mvp/tests/enterprise-core.test.mjs, all of which passed in the test environment (with noted FastAPI deprecation warnings only).docs/GOALOS_REPO_AUDIT.mdand the updatedrepository_manifest.jsonlists required validation scripts.Codex Task