Elevate GoalOS / Proof Gradient README, docs, figures, tables, badges, and validation#29
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 41b9dd776c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| for badge in REQUIRED_BADGES: | ||
| if f"badges/{badge}" not in cat: | ||
| errors.append(f"catalog badge_inventory missing badges/{badge}") |
There was a problem hiding this comment.
Require badge entries inside badge_inventory
In this new badge catalog check, the code searches the entire YAML text instead of the badge_inventory list, so a catalog can delete or rename badge_inventory: or leave these paths in comments/another section and still pass. Since this hardening is meant to make the catalog's badge inventory authoritative, validate the section itself (or parse YAML) before accepting these paths.
Useful? React with 👍 / 👎.
Motivation
Description
badge_inventoryand thedocs/tables/goalos_badge_inventory.csventry indocs/data/goalos_catalog.ymlso badges are verified by the catalog.scripts/validate_goalos_catalog.pyto require the full institutional table set, all required figure.mmd/.svgpairs, all static badge SVGs, and exact governance workflow names, and to cross-check those entries against the catalog.scripts/validate_docs_tables_figures.pyto includedocs/tables/goalos_badge_inventory.csvand to verify the required static badges as part of docs/tables/figures validation.docs/GOALOS_REPO_AUDIT.mdso operators and reviewers can see the validation commands, test results, and non-regression assurances.Testing
python scripts/check_no_paid_artifacts.pyand it passed (allowed public AEP package only).python scripts/validate_goalos_public_site.py,python scripts/validate_docs_tables_figures.py, andpython scripts/validate_goalos_catalog.pyand they passed after bringing the catalog into alignment with validator expectations.pytest(initially failed due to missinghttpx2/httpx, installed viapython -m pip install httpx2 httpx) andpytestthen passed with 85 tests and 2 deprecation warnings.make test(unittest discovery) which passed (56 tests) and the Node-based GoalOS Cloud MVP checknode site/app/goalos-cloud-mvp/tests/enterprise-core.test.mjswhich also passed.Codex Task