Unify GoalOS public site and add Cloud MVP 0.2 software proof#7
Unify GoalOS public site and add Cloud MVP 0.2 software proof#7MontrealAI wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
💡 Codex Review
https://github.com/MontrealAI/proof-gradient/blob/9065bf0cee80e69f3c3eecf60f100cc1143fece8/site/standards/AEP-001/complete-package.zip#L1
Regenerate public manifests after removing the ZIP
After this deletion, rg complete-package.zip site/*.json still finds site/site-manifest.json, site/goalos-product-ladder-site-manifest.json, site/goalos-complete-site-manifest.json, and site/goalos-unified-site-manifest.json listing standards/AEP-001/complete-package.zip, but the file is no longer present under site/. Any viewer or automation that treats those deployed manifests as the site inventory will advertise a downloadable artifact that now 404s, so the manifests should be regenerated or pruned as part of the removal.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 044a8c7784
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <header class="goalos-shell"> | ||
| <nav class="goalos-nav" aria-label="GoalOS canonical navigation"> |
There was a problem hiding this comment.
Finish canonicalizing the proof pages
When this page (and the two sibling proof pages changed the same way) gets the canonical shell inserted here, the old per-page <nav> remains before <main> and no GOALOS-CANONICAL-FOOTER:START is added. I checked the Pages workflows (.github/workflows/refresh-complete-goalos-public-site.yml and repair-goalos-canonical-shell-v2.yml), which run python scripts/validate_goalos_site_v2.py; running that command on this commit fails for these pages with duplicate topbar/header/nav blocks and missing canonical footer, so the deploy validation is blocked.
Useful? React with 👍 / 👎.
Motivation
Description
site/assets/goalos-site-v2.cssandsite/assets/goalos-site-v2.jsand unified public pages to include theGOALOS-CANONICAL-SHELLandGOALOS-CANONICAL-FOOTERmarkers.site/app/goalos-cloud-mvp/includingassets/enterprise-core.mjs,assets/app.js,assets/styles.css,schemas/*,openapi.json,tests/enterprise-core.test.mjs,README.md, and supporting manifest/docs.scripts/check_no_paid_artifacts.pyand hardenedscripts/validate_goalos_site_v2.pyto detect duplicate topbars, old GoalOS shell markers, broken internal/proof-gradient/links, and disallowed paid artifact patterns; removed the active public-site ZIPsite/standards/AEP-001/complete-package.zipfrom the deploy root to comply with the guard.docs/GOALOS_REPO_AUDIT.md,docs/GOALOS_PUBLIC_SITE_REPAIR.md,docs/GOALOS_CLOUD_MVP_0_2.md,docs/GOALOS_COMMERCIALIZATION_STATUS.md,docs/GOALOS_PAID_ARTIFACT_POLICY.md,docs/GOALOS_RECURSIVE_WORKFLOW_OS.md, and generatedsite/goalos-site-repair-v2-report.jsonandsite/goalos-site-manifest-v2.json; added/updated GitHub Actions workflows for shell repair, Cloud MVP build, and public-site refresh.Testing
node site/app/goalos-cloud-mvp/tests/enterprise-core.test.mjsand it passed (report: v11 compliance improved, graph nodes/edges present).python scripts/validate_goalos_site_v2.pyandpython scripts/check_no_paid_artifacts.pyand both passed for 206 public HTML pages and no paid/private artifacts in activesite/.pytest(72 tests passed, 3 warnings after installing editable dev deps),make test(56 unittest tests passed), and internal site/link/product validators (scripts/check_site_links.py,scripts/validate_goalos_products.py) — all passed.pytest/make testcollection required installing editable dev dependencies (python -m pip install -e .[dev]); after installing the editable package and dependencies the test suites passed and JSON artifacts (openapi.json, schemas, site manifests) validated successfully.Codex Task