GoalOS v10: public site, docs, assets, QUEBEC.AI seal, and validation release#9
GoalOS v10: public site, docs, assets, QUEBEC.AI seal, and validation release#9MontrealAI wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 697be1d38e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| dest = ARCHIVE / p.relative_to(SITE) | ||
| ensure(dest) | ||
| shutil.move(str(p), str(dest)) |
There was a problem hiding this comment.
Remove archived files from the Pages artifact
When archive_nonessential_standard_files() moves disallowed files into site/_archive, they are still included in the site directory uploaded by the release workflow and remain directly downloadable from GitHub Pages. The current commit already leaves .docx, .pdf, and .tex files under site/_archive/before_goalos_public_site_release_v10_2026-06-07/..., while check_no_paid_artifacts.py skips _archive, so the public artifact policy is bypassed rather than enforced. Archive these outside the deployed site root or delete them from site/ before upload.
Useful? React with 👍 / 👎.
| - name: Install Python validation dependencies | ||
| run: python -m pip install pyyaml pytest httpx2 |
There was a problem hiding this comment.
Drop the nonexistent httpx2 package from CI
This install step runs before any validation, and httpx2 is not a resolvable PyPI distribution (pip index versions httpx2 reports no matching distribution), so every pull request that triggers this new workflow fails before reaching the catalog/site checks. The release workflow has the same dependency line at .github/workflows/goalos-public-site-release-v10.yml:39, so both workflows need the dependency corrected or removed.
Useful? React with 👍 / 👎.
Motivation
Description
docs/data/goalos_catalog.ymland generatorscripts/generate_goalos_public_site_v10.pyto produce the v10 site and docs from one authoritative file.site/assets/brand/and producingsite/assets/brand-assets-v10.json, plus copying the official seal tosite/assets/quebecaisealv5.png,site/favicon.png, and app icons/manifest.site/index.html, product pages,site/workshop/goalos-rsi-sprint-workshop/index.html,site/brand/visual-system/index.html,site/app/goalos-cloud-mvp/placeholder), addedsite/assets/goalos-sovereign-v10.cssand.js, and archived superseded pages undersite/_archive/before_goalos_public_site_release_v10_<DATE>/.scripts/validate_goalos_catalog.py,scripts/validate_docs_tables_figures.py,scripts/check_no_paid_artifacts.py) and CI workflows (.github/workflows/goalos-public-site-release-v10.yml,validate-goalos-public-site-v10.yml,check-no-paid-artifacts.yml,validate-docs-tables-figures.yml) to automate generation, checks, and deploy steps while preserving AEP standard ZIP exceptions.Testing
python scripts/validate_goalos_catalog.pyandpython scripts/check_no_paid_artifacts.py, both passed (catalog, shell, links, seal/icons, and paid-file guard validated).python scripts/validate_docs_tables_figures.pywhich passed and verified docs/tables/figures presence and consistency with the catalog.node site/app/goalos-cloud-mvp/tests/enterprise-core.test.mjs,make test, andpython -m pytestwhich passed (72 tests passed; 2 deprecation warnings reported); local transient missinghttpx2dependency for Starlette tests was installed during QA and is noted in the release docs.mmdc) was not available during generation so Mermaid.mmdsources and fallback SVG stubs were committed and documented indocs/GOALOS_PUBLIC_SITE_RELEASE_V10.mdas a skipped tooling item.Codex Task