chore(deps): update dependency eslint-plugin-unicorn to v72 - abandoned - #322
Open
renovate[bot] wants to merge 6 commits into
Open
chore(deps): update dependency eslint-plugin-unicorn to v72 - abandoned#322renovate[bot] wants to merge 6 commits into
renovate[bot] wants to merge 6 commits into
Conversation
- Disabled several unicorn rules in eslint.config.js for better flexibility. - Simplified request body handling in api.ts by using URLSearchParams directly. - Improved state management in CheckboxGroup.vue and OptionsGroup.vue. - Enhanced pagination logic in Pagination.vue for better type handling. - Refactored AudioPlayerV2.ts to use Number() instead of Number.parseFloat(). - Optimized CVList.ts to skip skins without voiceId early. - Streamlined ISEvent.ts by using querySelector instead of querySelectorAll. - Updated ItemList.ts to simplify icon URL handling. - Enhanced VoiceTable.vue to use replaceAll with a callback for better clarity. - Refactored various components to improve performance and readability, including CharList, EquipGroup, and others. - Replaced deprecated methods and improved type handling across multiple files.
Contributor
Author
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
daflyinbed
reviewed
Aug 2, 2026
| filters[key].every( | ||
| (filter) => | ||
| !!~enemy[key as keyof EnemyData].toString().indexOf(filter), | ||
| !~enemy[key as keyof EnemyData].toString().indexOf(filter), |
Contributor
Author
Autoclosing SkippedThis PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^64.0.0→^72.0.0Release Notes
sindresorhus/eslint-plugin-unicorn (eslint-plugin-unicorn)
v72.0.0Compare Source
Breaking
prefer-minimal-ternary: RenamecheckVaryingCalleeoption tocheckVaryingBase(#3508)825b7b9New rules
no-missing-local-resource(#3528)12a33c6no-multiple-promise-resolver-calls(#3523)81ab092no-shorthand-property-overrides(#3527)91a4c4dno-transition-all(#3529)5ef2fcfno-unnecessary-string-trim(#3517)a651672no-useless-re-export(#3540)96afe55prefer-explicit-viewport-units(#3532)449e636prefer-then-catch(#3526)a17e5a2require-frontmatter-fields(#3525)dfd91cdImprovements
8233f95consistent-boolean-name: Support Vue refs (#3555)79e79d5no-incorrect-template-string-interpolation: Ignore Unicode code point escapes (#3513)36fdf1ano-negated-comparison: Ignore relational comparisons with optional chaining (#3512)7b7e28ano-top-level-side-effects: Ignore<script setup>(#3542)af8fd60no-unnecessary-array-flat-map: Handle TypeScript Vue files (#3545)b6d01a0no-unsafe-property-key: Use type information for narrowed property keys (#3515)69a6002no-unused-array-method-return: Ignore expect assertions (#3552)110cc58no-useless-promise-resolve-reject: Handleawaited calls (#3504)9b8a144no-useless-template-literals: Ignore const assertions (#3543)4367228prefer-await: Add async IIFE suggestion (#3550)305fb4bprefer-dom-node-html-methods: Add options and add torecommendedpreset (#3541)581ef47prefer-export-from: Preserve JSDoc comments on single-const re-exports (#3544)e273ab6prefer-short-arrow-method: Addconsistent-as-neededoption (#3514)c068745prefer-simple-condition-first: Fix logic (#3530)a339abeprefer-split-limit: Support array destructuring (#3554)b23f959prefer-string-starts-ends-with: Detect slice comparisons (#3518)98730deprefer-minimal-ternary: Don't report object-varying member access by default (#3508)825b7b9v71.1.0Compare Source
consistent-boolean-name: Allow async boolean predicates (#3502)dafc7c9consistent-boolean-name: Allow boolean-like React refs withRefsuffix (#3501)064d890v71.0.0Compare Source
Improvements
consistent-boolean-name: Ignore destructured variables (#3485)0de22c5consistent-boolean-name: Skip React hooks by default (#3487)fab07e2isolated-functions: Respect configured globals in isolated functions (#3495)1af1d1ano-unnecessary-array-flat-map: Ignore conditional flatMap fixes in TypeScript (#3499)5eb6d87prefer-boolean-return: Ignore repeated boolean guard clauses (#3494)fdb3d89prefer-top-level-await: Ignore Svelte files (#3489)58670ffprefer-uint8array-base64: Remove from presets (#3493)3f4c31ev70.0.0Compare Source
New rules
no-async-promise-finally(#3450)5aa9ea1no-unnecessary-fetch-options(#3476)db4e852no-unsafe-promise-all-settled-values(#3449)f66e080prefer-abort-signal-any(#3447)f044cefprefer-array-flat-map(#3457)7d48a41prefer-array-from-range(#3451)f3e12e9prefer-block-statement-over-iife(#3452)44a63daprefer-group-by(#3443)b3071b3prefer-iterator-helpers(#3446)18d9362prefer-simplified-conditions(#3474)93ee487Improvements
consistent-boolean-name: Add inverse boolean name support (#3478)d379e13expiring-todo-comments: Report unsupported catalog versions (#3455)26f11daisolated-functions: Add defaults for workerize and common evaluate APIs (#3467)30c7570isolated-functions: Support methods (#3470)c615523no-collection-bracket-access: Handle conditional member keys (#3462)cd01d0bno-manually-wrapped-comments: Handle more cases (#3460)c09d4c7no-non-function-verb-prefix: Addignoreoption (#3475)f9a422eno-return-array-push: Fix false-positives (#3448)5f4dd3ano-useless-else: Recognizeprocess.exit()as an exiting branch (#3482)46714a6prefer-continue: Ignore empty statements (#3473)df904a7prefer-early-return: Ignore empty statements (#3473)df904a7prefer-object-iterable-methods: Catch more callback methods (#3481)a076cbcv69.0.0Compare Source
v68.0.0Compare Source
Breaking
prevent-abbreviationsrule toname-replacements(#3362)af0158dAwesome
Now 300+ rules 🎉
New rules
consistent-conditional-object-spread(#3326)8aa1e0ddefault-export-style(#3364)0015e81no-accidental-bitwise-operator(#3318)af2661eno-array-concat-in-loop(#3350)4a1f65cno-array-front-mutation(#3323)d8302bdno-array-sort-for-min-max(#3351)e4b6666no-boolean-sort-comparator(#3368)3be859cno-chained-comparison(#3310)c29e211no-collection-bracket-access(#3286)6ccd694no-constant-zero-expression(#3311)134eea2no-double-comparison(#3329)ae4d7d7no-duplicate-if-branches(#3346)94b8c3bno-duplicate-logical-operands(#3348)af07fd8no-impossible-length-comparison(#3342)84dfd8bno-invalid-character-comparison(#3333)b2e9191no-loop-iterable-mutation(#3357)b961432no-misrefactored-assignment(#3315)063a798no-nonstandard-builtin-properties(#3337)14cc4dbno-selector-as-dom-name(#3328)6d9b14fno-unnecessary-boolean-comparison(#3349)00d90d4no-useless-compound-assignment(#3355)ddf347ano-useless-delete-check(#3359)2712e16no-useless-logical-operand(#3352)8689080no-xor-as-exponentiation(#3356)5b1952bprefer-array-from-async(#3370)b2bf08fprefer-array-iterable-methods(#3358)e32a7c3prefer-boolean-return(#3340)084bb9eprefer-continue(#3347)c374e14prefer-flat-math-min-max(#3341)3f0a2ceprefer-hoisting-branch-code(#3369)00d8a9bprefer-math-constants(#3309)6ee7dd8prefer-promise-with-resolvers(#3322)e880d29prefer-regexp-escape(#3367)dec6c31prefer-single-replace(#3353)9117778prefer-unary-minus(#3354)98c6f38prefer-url-can-parse(#3366)ba55624prefer-while-loop-condition(#3344)ce538b7Improvements
42abe7434ca8f6d7ce07eprefer-short-arrow-method: Remove fromrecommendedpreset (#3345)0cfd77aprefer-type-literal-last: Remove fromunopinionatedpreset and stop checking intersection types (#3320)447c665consistent-boolean-name: Do not check destructured bindings (#3324)fb0cfe0logical-assignment-operators: Do not assume the base rule'sdefaultOptionsexist (#3321)253e25flogical-assignment-operators: Improve error message (#3302)3ec8fecname-replacements: Add more default replacements (#3365)f968bf3new-for-builtins: Cover more builtins (#3361)e04ac43no-array-splice: Only report fresh, non-escaping local arrays (#3301)babb873no-break-in-nested-loop: Handle unlabeledcontinuein nestedswitchstatements (#3335)ca893bano-declarations-before-early-exit: Ignore initializers containingawaitoryield(#3303)6d98190no-incorrect-template-string-interpolation: Remove fromunopinionatedpreset and fix false-positive (#3319)39dc546no-manually-wrapped-comments: Ignore some more comments (#3292)a545dfeno-named-default: Don't drop comments in autofix (#3306)44e7361no-unsafe-property-key: Allow intrinsic string-mapping types as keys (#3343)ba6020fno-useless-coercion: Flag+value,value + '', andvalue.toString()idioms (#3338)23a52f6no-useless-undefined: Flagreturn undefinedforvoidreturn type (#3334)488d5e3prefer-array-find: Add.filter(…).slice(-1)support (#3360)b6ea1e2prefer-early-return: Fix lexical declaration autofixes (#3325)e7771bdprefer-identifier-import-export-specifiers: Check import attribute keys (#3287)fec43d2prefer-includes-over-repeated-comparisons: Ignore distinct expressions compared againstundefined(#3308)78858ecprefer-minimal-ternary: Report dynamic computed-key swaps (#3300)72879c4prefer-number-properties: AddparseFloatsupport (#3307)4b891d3prefer-object-iterable-methods: Preserve TypeScript casts on value access (#3327)d3a4d39v67.0.0Compare Source
New rules
consistent-boolean-name(#3237)8be0920logical-assignment-operators(#3246)7046694no-array-splice(#3235)d1143a9no-invalid-argument-count(#3243)ec091a9no-non-function-verb-prefix(#3242)5c32dd0no-top-level-assignment-in-function(#3234)e5ff667no-uncalled-method(#3231)f65ac01no-unreadable-for-of-expression(#3248)a8c7f89no-useless-coercion(#3283)3c76922no-useless-continue(#3276)5fd7d25no-useless-override(#3271)f503289operator-assignment(#3249)65ef58cprefer-array-slice(#3233)d9bce20prefer-else-if(#3232)98c2c2eprefer-has-check(#3250)a8d380dprefer-map-from-entries(#3255)01c0f82Improvements
no-unreadable-new-expression: Remove fromrecommendedpreset (#3285)c9f452ecomment-content: Remove fromrecommendedpreset (#3269)21cce8bcomment-content: AddcheckUniformCaseoption (#3269)21cce8bconsistent-class-member-order: Group static methods with other static members (#3239)8f4de02consistent-class-member-order: Improve error message (#3264)47f9f21dom-node-dataset: Flag.datasetassigned to a variable withpreferAttributes(#3268)79198ccno-array-reduce: SuggestMath.sumPrecise()for sum reduces (#3261)081936dno-return-array-push: Disallow usingpush()andunshift()return values (#3244)d9ea7abno-unreadable-array-destructuring: Disallow property targets (#3245)8b50359no-unreadable-object-destructuring: Disallow property targets (#3245)8b50359no-useless-fallback-in-spread: AddcheckTernaryoption (#3284)b2496fcprefer-logical-operator-over-ternary: Improve nullish ternary detection (#3240)4014a1eprefer-minimal-ternary: AddcheckComputedMemberAccessoption (#3241)cf4c014prefer-scoped-selector: Only apply to combined selectors (#3263)d715badprefer-scoped-selector: Report partially-scoped selector lists (#3259)cf88cddprefer-type-literal-last: Keepnullandundefinedlast (#3281)f6a9dceno-array-callback-reference: Harden the rule (#3230)dcc0cf8no-declarations-before-early-exit: Harden side-effect detection (#3238)1bad677no-declarations-before-early-exit: Ignore React hook calls (#3280)de47dcecomment-content: Skip non-prose comments (#3236)9c85b1fno-empty-file: Don't report non-empty files parsed by a plain-text parser (#3270)3b8b9a4no-unsafe-property-key: Don't flagunique symbolkeys (#3278)3fa567eno-unsafe-property-key: Ignore template literal types (#3247)b8d9602v66.0.0Compare Source
Breaking
93164fb93164fbno-array-for-eachrule tono-for-each(#3216)b87c8a9no-hex-escaperule (#3202)d68b09eprefer-unicode-code-point-escapes, which covers more cases.New rules
class-reference-in-static-methods(#3154)bbeb92fcomment-content(#3104)d14d0fdconsistent-class-member-order(#3226)d116a6bconsistent-export-decorator-position(#3175)9302e8dconsistent-function-style(#3137)a86fe5econsistent-optional-chaining(#3195)c07bf4eexplicit-timer-delay(#2814)29ae4ebid-match(#3109)d39bfa3max-nested-calls(#3183)0763b75no-asterisk-prefix-in-documentation-comments(#3191)4a95ff6no-break-in-nested-loop(#3148)41648c1no-computed-property-existence-check(#3151)af0e3c4no-confusing-array-with(#3178)95a748bno-declarations-before-early-exit(#3139)f7241c8no-duplicate-loops(#3142)745e9edno-error-property-assignment(#3114)bf9d72eno-global-object-property-assignment(#3136)b03927eno-incorrect-template-string-interpolation(#3162)32380f9no-mismatched-map-key([#&feat(MedalList): torappu implement #82Configuration
📅 Schedule: (UTC)
* 0-3 1 * *)🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.