Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/strict-server-cli-numbers.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@moonshot-ai/kimi-code": patch
---

Reject malformed numeric values for server CLI options instead of accepting partial decimal prefixes.
14 changes: 10 additions & 4 deletions apps/kimi-code/src/cli/sub/server/shared.ts
Original file line number Diff line number Diff line change
Expand Up @@ -129,19 +129,25 @@ function parseHost(raw: string | boolean | undefined): string {
return raw;
}

function parseDecimalInteger(raw: string): number | undefined {
if (!/^\d+$/.test(raw)) return undefined;
const n = Number(raw);
return Number.isSafeInteger(n) ? n : undefined;
}

function parseIdleGraceMs(raw: string | undefined): number {
if (raw === undefined) return DEFAULT_IDLE_GRACE_MS;
const n = Number.parseInt(raw, 10);
if (!Number.isFinite(n) || n < 0) {
const n = parseDecimalInteger(raw);
if (n === undefined) {
throw new Error(`error: invalid --idle-grace-ms value: ${raw}`);
}
return n;
}

export function parsePort(raw: string | undefined, label: string, fallback: number): number {
if (raw === undefined) return fallback;
const n = Number.parseInt(raw, 10);
if (!Number.isFinite(n) || n < 0 || n > 65535) {
const n = parseDecimalInteger(raw);
if (n === undefined || n > 65535) {
throw new Error(`error: invalid ${label} value: ${raw}`);
}
return n;
Expand Down
21 changes: 21 additions & 0 deletions apps/kimi-code/test/cli/server/server.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -663,6 +663,27 @@ describe('shared parsers stay strict', () => {
expect(parsePort('8080', '--port', 58627)).toBe(8080);
});

it('rejects --port values that are not complete decimal integers', async () => {
const { parsePort } = await import('#/cli/sub/server/shared');
expect(() => parsePort('123abc', '--port', 58627)).toThrow(/invalid --port/);
expect(() => parsePort('1.5', '--port', 58627)).toThrow(/invalid --port/);
expect(() => parsePort('10ms', '--port', 58627)).toThrow(/invalid --port/);
});

it('rejects --idle-grace-ms values that are not complete decimal integers', async () => {
const { parseServerOptions } = await import('#/cli/sub/server/shared');
expect(() => parseServerOptions({ idleGraceMs: '123abc' })).toThrow(
/invalid --idle-grace-ms/,
);
expect(() => parseServerOptions({ idleGraceMs: '1.5' })).toThrow(
/invalid --idle-grace-ms/,
);
expect(() => parseServerOptions({ idleGraceMs: '10ms' })).toThrow(
/invalid --idle-grace-ms/,
);
expect(parseServerOptions({ idleGraceMs: '1000' }).idleGraceMs).toBe(1000);
});

it('rejects unknown --log-level values', async () => {
const { parseLogLevel } = await import('#/cli/sub/server/shared');
expect(() => parseLogLevel('shout')).toThrow(/invalid --log-level/);
Expand Down