Skip to content

fix: moralis-v1 imports#272

Open
reiss-d wants to merge 3 commits intoMoralisWeb3:mainfrom
reiss-d:main
Open

fix: moralis-v1 imports#272
reiss-d wants to merge 3 commits intoMoralisWeb3:mainfrom
reiss-d:main

Conversation

@reiss-d
Copy link

@reiss-d reiss-d commented Aug 16, 2022


name: "fix moralis-v1 imports"

New Pull Request

Checklist

  • I am not disclosing a vulnerability.
  • My code is conform the code style
  • I have made corresponding changes to the documentation
  • I have updated Typescript definitions when needed

Issue Description

  1. moralis imports were not updated after the switch to the moralis-v1 fork.

  2. Type UseNFTTransfersParams used in the useNFTTransfers hook was incorrect.

Solution Description

  1. Updated all imports to the use moralis-v1, including the dev dependency.

  2. Fixed the UseNFTTransfersParams type by changing the property access from ["getTokenTransfers"] to ["getNFTTransfers"]

@Y0moo Y0moo self-requested a review August 23, 2022 09:23
@Y0moo
Copy link
Contributor

Y0moo commented Aug 23, 2022

Great job @Reiss2000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants