fix: Resilient patch bundle loading + quieter ADB logging + unique version output naming - #224
Open
prateek-who wants to merge 3 commits into
Open
fix: Resilient patch bundle loading + quieter ADB logging + unique version output naming#224prateek-who wants to merge 3 commits into
prateek-who wants to merge 3 commits into
Conversation
…nique output naming - Failing to load a patch source now properly throws an error instead of loading forever. We also show a banner mentioning that a patch source has failed to load. - abd logs are now quieter. Now only connect, disconnect, and status transitions are logged. - Output names already tried to encode the app version, but it came from the input filename, so a renamed input fell back to "patched" and different app versions overwrote each other. The app version is now read from the APK manifest (versionName) properly.
…(library and patcher) versions logging in logs and tools dialog - patcher version is now properly read from classpath instead of trusting the libs.toml file. - Patch load failures no longer surface as a blank "Failed to load". Full chain is logged and shown in the UI. (Even when the .message is null (might need more fixing in other places.) - Log the patcher and library info in the logs and the tools dialog.
LisoUseInAIKyrios
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.