Skip to content

fix: resolve deprecation warnings and fix list-versions accuracy - #225

Merged
prateek-who merged 3 commits into
MorpheApp:devfrom
krvstek:dev
Jul 29, 2026
Merged

fix: resolve deprecation warnings and fix list-versions accuracy#225
prateek-who merged 3 commits into
MorpheApp:devfrom
krvstek:dev

Conversation

@krvstek

@krvstek krvstek commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Cleans up compiler and deprecation warnings when building the JAR file, alongside bug fixes discovered while investigating the deprecations:

  • list-versions now correctly reports app-specific patches that have no version targets (previously skipped by an erroneous guard condition).
  • list-versions --count-unused-patches=false now correctly filters by patch.default instead of the deprecated patch.use, which always returned false in the new patcher and caused all patches to be excluded.
  • License dialog link buttons now correctly open external websites in the browser (replacing non-functional Desktop browser calls with LocalUriHandler).
  • Logger level tags now format without trailing space padding (e.g. [INFO] instead of [INFO ]).

Other changes are cosmetic maintenance to keep the build log clean.

@krvstek
krvstek marked this pull request as ready for review July 25, 2026 11:01
@prateek-who

prateek-who commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

I don't know if I'm remembering this correctly, but there seemed to be a better way to specify the "all OSes" part in the build.gradle.kts file. Would you happen to know anything about that? My IDE also points it out saying "Specify dependency directly."

@krvstek

krvstek commented Jul 25, 2026

Copy link
Copy Markdown
Contributor Author

I don't know if I'm remembering this correctly, but there seemed to be a better way to specify the "all OSes" part in the build.gradle.kts file. Would you happen to know anything about that?

I think there is no better solution at this moment than what I just pushed.

@krvstek
krvstek marked this pull request as draft July 25, 2026 19:51
@krvstek
krvstek marked this pull request as ready for review July 27, 2026 09:51
@krvstek krvstek changed the title chore: resolve compilation and deprecation warnings fix: resolve deprecation warnings and fix list-versions accuracy Jul 27, 2026
@krvstek krvstek changed the title fix: resolve deprecation warnings and fix list-versions accuracy fix: resolve deprecation warnings and fix list-versions accuracy Jul 27, 2026
@prateek-who
prateek-who merged commit 9b79d69 into MorpheApp:dev Jul 29, 2026
3 checks passed
github-actions Bot pushed a commit that referenced this pull request Jul 29, 2026
# [1.13.0-dev.2](v1.13.0-dev.1...v1.13.0-dev.2) (2026-07-29)

### Bug Fixes

* resolve deprecation warnings and fix `list-versions` accuracy ([#225](#225)) ([9b79d69](9b79d69))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants