-
-
Notifications
You must be signed in to change notification settings - Fork 450
Replace ASM + Gizmo with Java ClassFile API backport #4282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
evanchooly
wants to merge
31
commits into
master
Choose a base branch
from
replace-asm-gizmo-with-classfile-api
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3,160
−4,285
Open
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
fc3c714
Replace ASM and Gizmo with Java ClassFile API backport
claude 6e26221
Fix critter mapper test failures with ClassFile API backport
evanchooly 27d2f1b
removing dead code
evanchooly 1315dd7
remove outdated plugin reference
evanchooly 6509122
suppress unused for two methods called reflectively
evanchooly c8bcced
Fix VarHandleAccessorGenerator using system classloader for property …
evanchooly a1a0fbf
Remove audits/ from git tracking
evanchooly b5f7ba0
Revert accidental audits/ gitignore entry
evanchooly 10d4271
Fix PropertyFinder accepting static methods as property setters in ME…
evanchooly 4e77b16
remove references to gizmo
evanchooly 0c1784a
remove references to gizmo and asm
evanchooly 86acc7c
Fix null classloader NPE and consolidate duplicated generator utilities
evanchooly f533696
Guard against methods named exactly "is" or "get" crashing property d…
evanchooly 96d401d
Fix array annotation defaults compared by identity rather than value
evanchooly 2c9fea7
Replace builder-based annotation emission with ClassFile API impl gen…
evanchooly 5242a6d
Hybrid annotation approach: builders for Morphia, classfile attr + ge…
evanchooly 03f2c22
Add BytecodeDumpTest to generate ASM Textifier output for 5 represent…
evanchooly 462105f
copilot feedback
evanchooly 5473b93
Fix five bugs found in code review; centralize ClassModel reading in …
evanchooly f720d19
Support @ExternalEntity in critter pipeline
evanchooly 9b6a20a
Use Object in __readXxx/__writeXxx bridge descriptors; preserve excep…
evanchooly c530182
Fix setter visibility mismatch, remove computeTypeData, simplify prim…
evanchooly dba7904
Inline loop variable in toAnnotationValue array branch
evanchooly 5debf9a
use the descriptor rather than the name
evanchooly 68d4d3e
use more typesafe alternatives
evanchooly 06b4b22
Fix Session 4 review findings: unify setter lookup, fix primitive sig…
evanchooly e245b06
Fix Session 5 review findings: array hasSetter, dead classModel param…
evanchooly 574e599
Unify primitive ClassDesc lookup into GenerationUtils.primitiveClassD…
evanchooly 00445d1
static imports
evanchooly dcf9f3a
Fix Session 7 review findings: array VarHandle fallback, fluent sette…
evanchooly f8d3d28
Replace VarHandle accessors with hidden nestmate class approach
evanchooly File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
339 changes: 0 additions & 339 deletions
339
build-plugins/src/main/java/util/KotlinAnnotationExtensions.java
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.