SaveData Location changes#24
Merged
Merged
Conversation
…amed ".portable" besides the executable
Contributor
Author
|
the portable mode is similar-ish to how godot does it, where godot checks for a ._sc_ file, so there is precedence for this way |
Owner
|
I've also seen portable.txt being used for the same thing, but I guess that's more of a Windows thing. Looks good to me either way! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is threefold:
Fix a bug in code i did through copypasting a line of code
Savedata should now be in the little bit more sensical PreferencePath/MoonchildFE folder instead of PreferencePath/moonchild/moonchild
I had been observing yesterdays release of the twillight princess DUSK release and had seen the wish there often enough to have savedata be able to be saved besides the executable. Inspired me of this change, if a file named .portable exists besides the executable, then it should do the old behavior again of saving besides the executable.