Re-make of central functions - #43
Merged
Merged
Conversation
…to kostis-s-z/cleanup # Conflicts: # src/datacollective/client.py # tests/test_client.py
Kostis-S-Z
requested review from
moz-johanndiedrick and
moz-tello-wharton
and removed request for
moz-johanndiedrick
November 25, 2025 14:56
Kostis-S-Z
marked this pull request as ready for review
November 25, 2025 14:56
# Conflicts: # README.md # scripts/dev.py # src/datacollective/client.py
moz-tello-wharton
left a comment
Contributor
There was a problem hiding this comment.
The changes to .github/workflows/publish.yml... would you be able to share a little about the intended flow? It looks like it is getting quite complex.
Specifically, I am curious about how the flow is expected to work when it is main, and when it is release... and if perhaps those should be two separate files?
moz-tello-wharton
approved these changes
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Major updates
Create registry to handle dataset-specific loading functions. See README
Single source of truth for environment variables under api_utils.py
Remove setting multiple environments
Remove duplicate code by implementing a generic api_request() function to handle GET/POST requests
Remove
scriptsdir + code @moz-johanndiedrick was there a use for it in this repo?Minor updates
.ideadir) to.gitignore