Fix/9 Isolation of SECRETS#14
Open
falconmath27 wants to merge 1 commit intomainfrom
Open
Conversation
falconmath27
requested review from
Knight-Fury1102,
MrBottleTree and
RagavKrishnaRamesh
as code owners
falconmath27
changed the title
| @@ -1 +1 @@ | |||
| SECRET_KEY=paste_your_secret_key_here No newline at end of file | |||
| SECRET_KEY=os.getenv("SECRET_KEY") No newline at end of file | |||
Owner
There was a problem hiding this comment.
good job.
There are some small issues here.
'os.getenv' is used to get the value of a env variable FROM env TO python.
You have given example as os.getenv(...)
the previous value given in .env.example ("paste_your_secret_key_here") was appropriate.
Owner
There was a problem hiding this comment.
if you are adding this file, please make sure to ignore it in .gitignore.
MrBottleTree
requested changes
Jan 21, 2026
Owner
MrBottleTree
left a comment
MrBottleTree
left a comment
There was a problem hiding this comment.
Great work overall, just a few changes buddy and we can proceed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #13 Isolation of secrets