Skip to content

Update dependencies and base PHP requirement to 8.2 #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Msprg merged 6 commits into from
Feb 9, 2026
Merged

Update dependencies and base PHP requirement to 8.2 #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
68b0d78
Upgrade core dependencies: phpseclib 3.0.49, jQuery 3.7.1, Bootstrap …
Msprg Feb 9, 2026
c1ca186
Update CI checkout action and document current baremetal runtime requ…
Msprg Feb 9, 2026
440724e
Enforce PHP 8.2+ and required runtime extensions in Composer
Msprg Feb 9, 2026
9edaa26
Update PHP version requirement to 8.2+ in AGENTS.md and correct typo …
Msprg Feb 9, 2026
0b306d6
Enhance HTML sanitization in Bootstrap.js state handling to prevent X…
Msprg Feb 9, 2026
d414d09
Update public_html/bootstrap/js/bootstrap.js
Msprg Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
runner: ubuntu-22.04-arm
steps:
- name: Check out repository
uses: actions/checkout@v4
uses: actions/checkout@v6

- name: Prepare ref name
id: ref
Expand Down
2 changes: 1 addition & 1 deletion AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ See `migrations/00x.php` for schema.
- Sync: `sync_request`, `external_key`

## Development and runtime notes
- PHP 5.6+ (legacy), MySQL/MariaDB, LDAP.
- PHP 8.2+, MySQL/MariaDB, LDAP.
- Docker is the preferred deployment method (`Dockerfile`, `docker-compose.yml`).
- Cron and supervisor configs live under `etc/`.
- Web assets in `public_html/` (Bootstrap + jQuery).
Expand Down
13 changes: 7 additions & 6 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,18 +25,19 @@ Requirements
* Docker engine

<details>
<summary>Baremeteal requirements (old, deprecated, use docker if possible)</summary>
<summary>Baremetal requirements (old, deprecated, use docker if possible)</summary>
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Typo inconsistency: Line 28 corrected to "Baremetal" but Line 60 still says "Baremeteal".

Line 60 retains the old typo Baremeteal while Line 28 has been corrected to Baremetal.

Proposed fix 
-<summary>Baremeteal install (old, deprecated, use docker if possible)</summary>
+<summary>Baremetal install (old, deprecated, use docker if possible)</summary>
🤖 Prompt for AI Agents 
In `@README.md` at line 28, Fix the typo inconsistency by replacing the incorrect
header text "Baremeteal" with "Baremetal" where it still appears (the README
header that currently reads "Baremeteal requirements (old, deprecated, use
docker if possible)"); ensure the header text matches the corrected form used
earlier ("Baremetal requirements (old, deprecated, use docker if possible)").


* An LDAP directory service
* Apache 2.2 or higher
* PHP 5.6 or higher
* Apache 2.4 or higher
* PHP 8.2 or higher
* Composer
* PHP JSON extension
* PHP LDAP extension
* PHP mbstring (Multibyte String) extension
* PHP MySQL extension
* PHP GMP extension (not strictly needed, but a big performance improvement)
* MySQL (5.5+), Percona Server (5.5+) or MariaDB database
* PHP SSH2 extension
* PHP GMP extension (recommended for better crypto performance)
* MySQL (8.0+), Percona Server (8.0+) or MariaDB database (10.11+)

</details>

Expand All @@ -56,7 +57,7 @@ Installation


<details>
<summary>Baremeteal install (old, deprecated, use docker if possible)</summary>
<summary>Baremetal install (old, deprecated, use docker if possible)</summary>

1. Clone the repo somewhere outside of your default Apache document root.

Expand Down
6 changes: 6 additions & 0 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,12 @@
"description": "A tool for managing user and server SSH access to any number of servers.",
"type": "project",
"require": {
"php": "^8.2",
"ext-ldap": "*",
"ext-mbstring": "*",
"ext-mysqli": "*",
"ext-pcntl": "*",
"ext-ssh2": "*",
Comment on lines +6 to +11
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

PHP 8.2+ requirement contradicts the coding guideline for **/*.php which states "PHP 5.6+ is the minimum supported version".

The composer.json now requires ^8.2, which is a breaking change relative to the documented coding guideline. If this is intentional (as the README update and PR title suggest), the coding guideline should be updated to reflect PHP 8.2+ as the new minimum. Otherwise, any PHP 5.6/7.x users would be broken.

The extension requirements (ext-ldap, ext-mbstring, ext-mysqli, ext-pcntl, ext-ssh2) are sensible and align with the README updates. As per coding guidelines, "PHP 5.6+ is the minimum supported version".

🤖 Prompt for AI Agents 
In `@composer.json` around lines 6 - 11, The composer.json now specifies "php":
"^8.2" which conflicts with the documented coding guideline line stating "PHP
5.6+ is the minimum supported version"; either update the coding
guideline/readme to state PHP 8.2+ as the new minimum (search for the literal
"PHP 5.6+ is the minimum supported version" in the docs and replace it with "PHP
8.2+"), or revert the composer.json php constraint back to the previous minimum
(e.g., "^5.6 || ^7.0 || ^8.0" or the project’s prior value) so both the
composer.json entry and the coding guideline remain consistent; keep the
extension requirements (ext-ldap, ext-mbstring, ext-mysqli, ext-pcntl, ext-ssh2)
as-is.

"phpseclib/phpseclib": "^3.0"
},
"license": "Apache-2.0"
Expand Down
39 changes: 24 additions & 15 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docker-compose.yml.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ services:
retries: 3
start_period: 30s
ska-db:
image: mariadb:lts
image: mariadb:11.8.5
container_name: ska-db
restart: unless-stopped
environment:
Expand Down
Loading