feat(transform): add Rust discrete-mixture transform and wire it into Python API#38
Merged
MthwRobinson merged 9 commits intomainfrom Mar 25, 2026
Merged
feat(transform): add Rust discrete-mixture transform and wire it into Python API#38MthwRobinson merged 9 commits intomainfrom
MthwRobinson merged 9 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a Rust implementation of discrete mixture transforms and switches Python’s
_mixture_discretepath to use the Rust binding for faster and more consistent behavior.What changed
mixture_discreteinrust/src/algorithms/transform.rs:random_variablesvsmix_weights)Sumsupport forNumberinrust/src/algorithms/number.rsto support cleaner weight-sum validation.mixture_discrete_pyinrust/src/python/api.rsrust/src/lib.rsapplpy/transform.pyso_mixture_discretecallsapplpy_rust.mixture_discrete(...)and returns anRVfrom the Rust result.mixture_discreteOverall, the branch replaces Python-side discrete mixture accumulation with a Rust-backed implementation and adds validation/tests around the new behavior.
Testing
Run the following from the repository root:
make cargo-checkmake cargo-testmake checkmake rust-developmake test