feat(algebra): implement discrete RV product in Rust and wire Python RV multiplication#39
Merged
MthwRobinson merged 11 commits intomainfrom Mar 27, 2026
Merged
feat(algebra): implement discrete RV product in Rust and wire Python RV multiplication#39MthwRobinson merged 11 commits intomainfrom
MthwRobinson merged 11 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR moves discrete random-variable product logic from Python to Rust and routes
RVmultiplication through the Rust-backedFastRVpath.Key changes included in this branch:
product_discretefor independent discrete RVs, including:impl Mul for RandomVariable,impl Mul for FastRV,product_discretebinding.rust/src/lib.rs._product_discreteNumPy implementation fromapplpy/algebra.py,product()useto_fast_rv()/from_fast_rv()for discrete RV multiplication,RV.to_fast_rv()andRV.from_fast_rv()helpers inapplpy/rv.py,RV.from_fast_rv()inbootstrap_rv.conversiontypo fixes).Testing
Run the following from the repository root:
For Rust changes:
make cargo-checkmake cargo-testFor Python changes:
make checkmake rust-developmake test