Skip to content

Move to updated PID model, add track dt/dt fit info - #386

Open
michaelmackenzie wants to merge 5 commits into
Mu2e:mainfrom
michaelmackenzie:TrkPID
Open

Move to updated PID model, add track dt/dt fit info#386
michaelmackenzie wants to merge 5 commits into
Mu2e:mainfrom
michaelmackenzie:TrkPID

Conversation

@michaelmackenzie

Copy link
Copy Markdown
Contributor

This follows PRs Mu2e/MLTrain#9 and Mu2e/ArtAnalysis#8 to update the input PID model and to also add an optional branch with the track dt/dt fit results. I added rooutil information as well and a test script plotting the results.

@AndrewEdmonds11 AndrewEdmonds11 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks, Michael. Could you also add the new branch to the ntuplehelper and recreate branches.md? Thanks

@michaelmackenzie

Copy link
Copy Markdown
Contributor Author

Looks great! Thanks, Michael. Could you also add the new branch to the ntuplehelper and recreate branches.md? Thanks

I just added this, thanks for reminding me!

@oksuzian

oksuzian commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Issues in PR #386:

  1. Branch misalignment risk (src/EventNtupleMaker_module.cc) — when the DtDt handle is invalid or shorter than the KalSeedPtr collection, nothing is pushed, so trkdtdt ends up shorter/misaligned with trk. RooUtil assumes 1:1. Fix: default-fill a TrkDtDtInfo for missing entries.

  2. handle->at(i_kseedptr) can throw — if the DtDt collection is valid but smaller than the seed collection.

  3. branches.md regression — regenerated from an older base; drops previously-merged Calorimeter/CRV/Trigger docs (field tables, calohitsmc alignment warning, trigger array explanation).

  4. Empty CRV explanation columnscrvpulses, crvdigis, crvpulsesmc rows now have blank explanations in branches.md.

  5. Wrong leaf linkcrvpulsesmc now points to CrvPulseInfoReco.hh (reco) instead of an MC struct.

  6. Missing trkDtDtTag on De fit config (fcl/prolog.fcl) — with fillTrkDtDt set globally true, fit branches lacking a trkDtDtTag get an empty tag → invalid handle → misaligned/empty branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants