Skip to content

微调了“隐藏曲目信息”的表现#139

Merged
clansty merged 1 commit into
MuNET-OSS:mainfrom
Minepig:dev
Jul 10, 2026
Merged

微调了“隐藏曲目信息”的表现#139
clansty merged 1 commit into
MuNET-OSS:mainfrom
Minepig:dev

Conversation

@Minepig

@Minepig Minepig commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

原来打开这个功能以后用来展示历史分数的框会保留一个默认图像,改成了直接隐藏掉整个框

Summary by Sourcery

增强内容:

  • 当赛道信息被隐藏时,通过禁用默认成就和段位图片的 GameObject,而不是替换精灵(sprite),从赛道开始面板中移除这些默认成就和段位图片。
Original summary in English

Summary by Sourcery

Enhancements:

  • Remove default achievement and rank images from the track start panel when track information is hidden by disabling their GameObjects instead of swapping sprites.

@sourcery-ai

sourcery-ai Bot commented Jul 10, 2026

Copy link
Copy Markdown
审阅者指南(在小型 PR 上折叠)

审阅者指南

此 PR 调整了 “hide track info” 模组:在启用该功能时,不再将等级/成就的贴图替换为默认图片,而是彻底隐藏分数/通关/连击/同步等 UI 元素。

更新后的 hide_track_info UI 行为流程图

flowchart LR
    A[HideTrackInfo_mod_enabled] --> B[DisableTrackStartTabs.Apply]
    B --> C[Traverse.Create ____musicDetail]
    C --> D[Hide achivement_Base]
    C --> E[Hide clearRank_Base]
    C --> F[Hide comboRank_Image]
    C --> G[Hide syncRank_Image]
    C --> H[Hide related_text_and_score_objects]
Loading

文件级变更

变更 详情 文件
当曲目信息被禁用时,将行为从“替换为默认贴图”改为“完全隐藏成就和通关等级基础图片”。
  • 将成就基础图片上的 ChangeSprite 调用替换为对其 GameObject 调用 SetActive(false)。
  • 将通关等级基础图片上的 ChangeSprite 调用替换为对其 GameObject 调用 SetActive(false)。
AquaMai.Mods/Fancy/GamePlay/DisableTrackStartTabs.cs
当曲目信息被禁用时,完全隐藏连击和同步等级图片,而不是重置它们的贴图。
  • 将连击等级图片上的 ChangeSprite 调用替换为对其 GameObject 调用 SetActive(false)。
  • 将同步等级图片上的 ChangeSprite 调用替换为对其 GameObject 调用 SetActive(false)。
AquaMai.Mods/Fancy/GamePlay/DisableTrackStartTabs.cs

技巧和命令

与 Sourcery 交互

  • 触发新审阅: 在 pull request 中评论 @sourcery-ai review
  • 继续讨论: 直接回复 Sourcery 的审阅评论。
  • 从审阅评论生成 GitHub Issue: 通过回复审阅评论让 Sourcery 从该评论创建 issue。也可以回复审阅评论并写上 @sourcery-ai issue 来创建 issue。
  • 生成 pull request 标题: 在 pull request 标题中的任意位置写上 @sourcery-ai,即可随时生成标题。也可以在 pull request 中评论 @sourcery-ai title 来(重新)生成标题。
  • 生成 pull request 摘要: 在 pull request 正文中的任意位置写上 @sourcery-ai summary,即可在该位置生成 PR 摘要。也可以在 pull request 中评论 @sourcery-ai summary 来在任何时间(重新)生成摘要。
  • 生成审阅者指南: 在 pull request 中评论 @sourcery-ai guide,即可在任何时间(重新)生成审阅者指南。
  • 解决所有 Sourcery 评论: 在 pull request 中评论 @sourcery-ai resolve,即可解决所有 Sourcery 评论。适用于你已处理完所有评论且不想再看到它们的情况。
  • 忽略所有 Sourcery 审阅: 在 pull request 中评论 @sourcery-ai dismiss,即可忽略所有现有的 Sourcery 审阅。尤其适用于你想从头开始新一轮审阅——别忘了再评论 @sourcery-ai review 来触发新的审阅!

自定义你的体验

访问你的控制面板 来:

  • 启用或禁用审阅功能,例如 Sourcery 自动生成的 pull request 摘要、审阅者指南等。
  • 更改审阅语言。
  • 添加、删除或编辑自定义审阅说明。
  • 调整其他审阅设置。

获取帮助

Original review guide in English
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR adjusts the “hide track info” mod so that, instead of swapping rank/achievement sprites to default images, it fully hides the score/clear/combo/sync UI elements when the feature is enabled.

Flow diagram for updated hide_track_info UI behavior

flowchart LR
    A[HideTrackInfo_mod_enabled] --> B[DisableTrackStartTabs.Apply]
    B --> C[Traverse.Create ____musicDetail]
    C --> D[Hide achivement_Base]
    C --> E[Hide clearRank_Base]
    C --> F[Hide comboRank_Image]
    C --> G[Hide syncRank_Image]
    C --> H[Hide related_text_and_score_objects]
Loading

File-Level Changes

Change Details Files
Change behavior from swapping default sprites to completely hiding achievement and clear rank base images when track info is disabled.
  • Replace ChangeSprite calls on achievement base image with SetActive(false) on its GameObject.
  • Replace ChangeSprite calls on clear rank base image with SetActive(false) on its GameObject.
AquaMai.Mods/Fancy/GamePlay/DisableTrackStartTabs.cs
Fully hide combo and sync rank images instead of resetting their sprites when track info is disabled.
  • Replace ChangeSprite calls on combo rank image with SetActive(false) on its GameObject.
  • Replace ChangeSprite calls on sync rank image with SetActive(false) on its GameObject.
AquaMai.Mods/Fancy/GamePlay/DisableTrackStartTabs.cs

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates DisableTrackStartTabs.cs to hide several UI elements (_achivement_Base, _clearRank_Base, _comboRank_Image, and _syncRank_Image) by setting their game objects to inactive instead of changing their sprites. There are no review comments, and I have no additional feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - 我在这里给出一些整体性的反馈:

  • 既然你现在在赛道起始面板上隐藏多个独立的元素,可以考虑直接禁用父级容器的 GameObject,这样可以简化逻辑,并减少遗漏某个子元素的风险。
面向 AI Agent 的提示
请根据本次代码评审中的评论进行修改:

## 总体意见
- 既然你现在在赛道起始面板上隐藏多个独立的元素,可以考虑直接禁用父级容器的 GameObject,这样可以简化逻辑,并减少遗漏某个子元素的风险。

Sourcery 对开源项目免费——如果你觉得我们的评审有帮助,欢迎分享 ✨
帮我变得更有用!请在每条评论上点 👍 或 👎,我会根据你的反馈改进后续评审。
Original comment in English

Hey - I've left some high level feedback:

  • Since you’re now hiding multiple individual elements on the track start panel, consider disabling the parent container GameObject instead to simplify the logic and reduce the chance of missing a child element.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Since you’re now hiding multiple individual elements on the track start panel, consider disabling the parent container GameObject instead to simplify the logic and reduce the chance of missing a child element.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@clansty clansty merged commit 97084b3 into MuNET-OSS:main Jul 10, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants