Pin Python below 3.14 to resolve OpenFF-related CI failures - #87
Merged
Conversation
dwhswenson
previously approved these changes
Jun 26, 2026
dwhswenson
left a comment
Contributor
There was a problem hiding this comment.
Nothing blocking, but gentle recommendation to put the "why we pinned" as comments on the same line as the pin. It's less of a hassle later. (But better to explain than not to!)
Marking approve; changes optional.
Co-authored-by: David W.H. Swenson <david.swenson@omsf.io>
Collaborator
Author
|
@dwhswenson Thanks for the swift review! I've tested locally that this pin passes CI, but that won't reflect in this PR since the CI config in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is a quick resolution to the repo-wide CI failures (beginning between 06/20 to 06/23) due to type errors caused by the interaction of Pydantic and openff.units within the
openff-toolkit, as referenced in this PR.Directly from the OpenFF maintainers:
Todos
Notable points that this PR has either accomplished or will accomplish.
Status