fix: reject batch run_mode for synchronous tool/HITL actions at valid…#100
Merged
Muizzkolapo merged 2 commits intomainfrom Apr 2, 2026
Merged
fix: reject batch run_mode for synchronous tool/HITL actions at valid…#100Muizzkolapo merged 2 commits intomainfrom
Muizzkolapo merged 2 commits intomainfrom
Conversation
…ation time Previously, configuring run_mode=batch with kind=tool or kind=hitl silently fell through to online mode at runtime with no warning. This caused config dishonesty and made debugging batch failures difficult. - Extend VendorCompatibilityValidator to emit a hard error when kind is tool or hitl with run_mode=batch - Add logger.warning at the runtime override site as defense-in-depth - Add 8 tests covering validation rejection and runtime warning Closes #85
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VendorCompatibilityValidatorto emit a hard error whenkind: toolorkind: hitlis combined withrun_mode: batchlogger.warningat the runtime override site inpipeline.pyas defense-in-depthTest plan
pytestpasses (4287 tests, 0 failures)ruff check .clean on changed filesruff format --check .clean on changed filesmodel_vendor: tool+ batch validation still workskind: tool+run_mode: onlineis unaffectedCloses #85