refactor: consolidate ProcessingMode into RunMode (ARCH-002)#102
Merged
Muizzkolapo merged 3 commits intomainfrom Apr 2, 2026
Merged
refactor: consolidate ProcessingMode into RunMode (ARCH-002)#102Muizzkolapo merged 3 commits intomainfrom
Muizzkolapo merged 3 commits intomainfrom
Conversation
… truth (#83) Remove the duplicate `ProcessingMode` enum from `processing/types.py` (ONLINE | BATCH) and replace all usages with `RunMode` from `config/types.py`. Eliminate the `is_batch_mode` boolean bridge in `PreparationContext` so the mode flows as a typed enum end-to-end, removing unnecessary round-trip conversions. - Delete `ProcessingMode` from `processing/types.py` - Update `ProcessingContext.mode` to use `RunMode` - Replace `is_batch_mode: bool` with `mode: RunMode` on `PreparationContext` - Remove bridge conversion in `TaskPreparer._render_prompt()` - Update all imports across 12 production files and 5 test files - Update stale docstring in `config/interfaces.py` Closes #83
- Remove duplicate `from agent_actions.config.types import RunMode` local import in test_invocation_strategy.py (already at module level) - Update processing/_MANIFEST.md to reflect RunMode usage in prepared_task.py and types.py
Muizzkolapo
force-pushed
the
arch-002/consolidate-runmode-enum
branch
from
4ae8732 to
41582fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProcessingModeenum fromprocessing/types.pyand replaces all usages withRunModefromconfig/types.pyis_batch_modeboolean bridge inPreparationContext, replacing it with a directmode: RunModefield so mode flows as a typed enum end-to-endTaskPreparer._render_prompt()and a stale docstring inconfig/interfaces.pyChanges (17 files)
processing/types.pyProcessingMode, addedRunModeimport, updatedProcessingContext.modeprepared_task.py,task_preparer.pyis_batch_mode: bool→mode: RunMode; removed boolean reconversionProcessingMode→RunModeacross processing, workflow, prompt, and input modulesconfig/interfaces.pyTest plan
ruff check .— all cleanpytest— 4279 passed, 2 skipped, 0 failuresgrep -rn "processing.types.*ProcessingMode"— zero hitsgrep -rn "is_batch_mode"— zero hitsconfig/interfaces.py::ProcessingMode(SYNC/ASYNC/AUTO) confirmed unchangedCloses #83
🤖 Generated with Claude Code