fix: static type checker recognizes output_field as a field producer#69
Merged
Muizzkolapo merged 5 commits intomainfrom Apr 1, 2026
Merged
Conversation
The schema extractor hardcoded {raw_response, content} for non-JSON-mode
actions without a schema, ignoring the output_field config key. Downstream
actions observing the named output_field were rejected with false
StaticTypeErrors.
Read output_field from the action config (defaulting to "raw_response")
so the checker knows the actual field name the action will produce.
End-to-end test that a downstream action can observe an output_field-produced field through the full analyzer pipeline. Directly reproduces the original bug report scenario.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{raw_response, content}for non-JSON-mode schemaless actions, ignoring theoutput_fieldconfig keyoutput_fieldwere rejected with falseStaticTypeErrors (19 errors on a 7-action workflow)output_fieldfrom the action config so the checker knows the actual field name produced at runtimeChanges
schema_extractor.py: Readoutput_fieldfrom config (defaulting to"raw_response"viaget_default()) instead of hardcoding"raw_response"test_schema_extractor.py: Two new tests — customoutput_fieldproduces the named field; regression guard for default behaviorTest plan
pytest tests/validation/static_analyzer/— 153 passedruff check— cleanruff format --check— cleanagac run -a support_resolutionto confirm zero false-positive errors on the example workflow