LoongArch64: Fix build with multiple bit depths - #941
Merged
Conversation
The loongarch64 assembly files are only compiled for 8-bit builds (CMakeLists.txt: LOONGARCH64 AND NOT HIGH_BIT_DEPTH). However, asm-primitives.cpp was compiled for all bit depths, causing compilation errors in 10-bit and 12-bit builds because the assembly functions with PFX() namespace prefix don't exist for those depths. Fix by wrapping all loongarch64-specific PFX-dependent code in #if !HIGH_BIT_DEPTH guard, and providing an empty setupAssemblyPrimitives for HIGH_BIT_DEPTH builds. Signed-off-by: Pluto Yang <yangyj.ee@gmail.com>
setarcos
added a commit
to lcpu-club/loongarch-packages
that referenced
this pull request
Aug 8, 2026
* Fix build with multiple bit depths. See also: Multicorewareinc/x265#941
mcw-Lavanya
approved these changes
Aug 11, 2026
mcw-Lavanya
left a comment
mcw-Lavanya
left a comment
Collaborator
There was a problem hiding this comment.
Code looks good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The loongarch64 assembly files are only compiled for 8-bit builds (CMakeLists.txt: LOONGARCH64 AND NOT HIGH_BIT_DEPTH). However, asm-primitives.cpp was compiled for all bit depths, causing compilation errors in 10-bit and 12-bit builds because the assembly functions with PFX() namespace prefix don't exist for those depths.
Fix by wrapping all loongarch64-specific PFX-dependent code in #if !HIGH_BIT_DEPTH guard, and providing an empty setupAssemblyPrimitives for HIGH_BIT_DEPTH builds.