Correct ref sequence filtering in consensus function#37
Open
mjohnpayne wants to merge 2 commits intoMultipathogenGenomics:stagingfrom
Open
Correct ref sequence filtering in consensus function#37mjohnpayne wants to merge 2 commits intoMultipathogenGenomics:stagingfrom
mjohnpayne wants to merge 2 commits intoMultipathogenGenomics:stagingfrom
Conversation
In the modified list comprehension the ref from self.refs was the full fasta header (including description) while it was being matched against ref_seq_names which had the description removed. Modified the comprehension to remove description from ref to do matching
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the modified list comprehension the ref from self.refs was the full fasta header (including description) while it was being matched against ref_seq_names which had the description removed.
Modified the comprehension to remove description from ref to do matching
Also added -MappingRefTable to argparsers utility as per #36