Skip to content

Add appgen observability variable and lightning vars to support sagemaker endpoint#138

Merged
hassimnaseef merged 3 commits into
mainfrom
hassimnaseef/infra-2563-add-env-variables-for-appgen-observability
Jun 23, 2026
Merged

Add appgen observability variable and lightning vars to support sagemaker endpoint#138
hassimnaseef merged 3 commits into
mainfrom
hassimnaseef/infra-2563-add-env-variables-for-appgen-observability

Conversation

@hassimnaseef

@hassimnaseef hassimnaseef commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores

    • Updated Helm chart version to 0.96.0.
  • New Features

    • Added inference backend configuration (including SageMaker endpoint support across multiple inference modes).
    • Added OPENCODE_OTLP_ENDPOINT to the runtime configuration for improved observability.
    • Extended Lightning deployment configuration with additional inference-related environment variables.

Hassim Naseef added 2 commits June 23, 2026 18:21
Add lightning vars to support sagemaker endpoint
@linear

linear Bot commented Jun 23, 2026

Copy link
Copy Markdown

INFRA-2563

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b034785f-bff6-4836-9f85-f11ca1f924cc

📥 Commits

Reviewing files that changed from the base of the PR and between b8adb41 and 0ab5724.

📒 Files selected for processing (2)
  • charts/multiwoven/templates/lightning-config.yaml
  • charts/multiwoven/values.yaml
🚧 Files skipped from review as they are similar to previous changes (2)
  • charts/multiwoven/values.yaml
  • charts/multiwoven/templates/lightning-config.yaml

📝 Walkthrough

Walkthrough

The Helm chart is bumped from 0.95.1/0.95.0 to 0.96.0. New default values are introduced in values.yaml for inferenceBackend, nine *SagemakerEndpoint fields under lightningConfig, and opencodeOtlpEndpoint under sandboxConfig. These values are then wired as environment variables into the Lightning and multiwoven ConfigMap templates.

Changes

Helm Chart v0.96.0 – Inference and OTLP env var additions

Layer / File(s) Summary
New values.yaml defaults for inference and sandbox OTLP
charts/multiwoven/values.yaml
Adds inferenceBackend: "huggingface" and nine empty *SagemakerEndpoint keys under lightningConfig, plus opencodeOtlpEndpoint under sandboxConfig.
ConfigMap templates wired to new values
charts/multiwoven/templates/lightning-config.yaml, charts/multiwoven/templates/multiwoven-config.yaml
lightning-config.yaml adds INFERENCE_BACKEND, AWS_REGION, and all *_SAGEMAKER_ENDPOINT entries; multiwoven-config.yaml adds OPENCODE_OTLP_ENDPOINT, each templated from the new values.yaml fields.
Chart version bump to 0.96.0
charts/multiwoven/Chart.yaml
version updated to 0.96.0 and appVersion updated to "0.96.0".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

  • Multiwoven/helm-charts#107: Introduced the Lightning service deployment and its initial ConfigMap wiring that this PR extends with new inference/SageMaker env vars.
  • Multiwoven/helm-charts#108: Also extends Lightning configuration by adding Lightning-related environment variables and values.yaml keys, the same pattern used here.
  • Multiwoven/helm-charts#130: Modifies lightning-config.yaml and values.yaml for Lightning-specific env vars, directly overlapping with the same ConfigMap data being extended in this PR.

Suggested labels

deploy-to-staging

Suggested reviewers

  • AngeloB-AIS

Poem

🐇 Hop hop, the chart climbs high,
From ninety-five to ninety-six we fly!
SageMaker endpoints, nine in a row,
OTLP tracing joins the Helm-chart show.
With inferenceBackend set to hug,
This bunny ships configs snug as a bug! 🌟

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main changes: adding observability variables for appgen (OPENCODE_OTLP_ENDPOINT) and lightning-related SageMaker endpoint configurations across multiple service templates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch hassimnaseef/infra-2563-add-env-variables-for-appgen-observability

Comment @coderabbitai help to get the list of available commands.

@hassimnaseef hassimnaseef changed the title Add appgen observability variables and lightning vars to support sagemaker endpoint Add appgen observability variable and lightning vars to support sagemaker endpoint Jun 23, 2026
@hassimnaseef hassimnaseef merged commit 2a86f7f into main Jun 23, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant