chore: add env vars- AGENTIC_CODING_DEPLOY_ROTATE_ENABLED and AGENTIC…#139
Conversation
…_CODING_BUILD_TOKEN
📝 WalkthroughWalkthroughThe Helm chart adds two new agentic coding configuration entries ( ChangesAgentic Coding Config Vars and Chart Version Bump
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@charts/multiwoven/templates/multiwoven-config.yaml`:
- Line 11: `AGENTIC_CODING_BUILD_TOKEN` is being rendered in the ConfigMap
template, but it is secret-bearing and should not live in config data. Update
the `multiwoven-config.yaml` template so this value is removed from the
ConfigMap and instead wired through a Kubernetes Secret or secrets-store
reference, and adjust any related Helm values usage so the workload still reads
it via the secret-backed path. Use the `AGENTIC_CODING_BUILD_TOKEN` key in
`multiwoven-config.yaml` as the place to relocate this handling.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 93f5ca58-abb4-4d36-aa6d-7fd33a97833d
📒 Files selected for processing (3)
charts/multiwoven/Chart.yamlcharts/multiwoven/templates/multiwoven-config.yamlcharts/multiwoven/values.yaml
| {{- include "chart.labels" . | nindent 4 }} | ||
| data: | ||
| ACTIVE_STORAGE_SERVICE: {{ .Values.multiwovenConfig.activeStorageService | quote }} | ||
| AGENTIC_CODING_BUILD_TOKEN: {{ .Values.sandboxConfig.agenticCodingBuildToken | quote }} |
There was a problem hiding this comment.
🔒 Security & Privacy | 🟠 Major | 🏗️ Heavy lift
Move AGENTIC_CODING_BUILD_TOKEN out of ConfigMap data.
AGENTIC_CODING_BUILD_TOKEN is a secret-bearing value and should be sourced from a Kubernetes Secret (or secrets store path), not stored in a ConfigMap.
Suggested change in this template
data:
ACTIVE_STORAGE_SERVICE: {{ .Values.multiwovenConfig.activeStorageService | quote }}
- AGENTIC_CODING_BUILD_TOKEN: {{ .Values.sandboxConfig.agenticCodingBuildToken | quote }}
AGENTIC_CODING_DB_PROVIDER: {{ .Values.sandboxConfig.agenticCodingDbProvider | quote }}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| AGENTIC_CODING_BUILD_TOKEN: {{ .Values.sandboxConfig.agenticCodingBuildToken | quote }} |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@charts/multiwoven/templates/multiwoven-config.yaml` at line 11,
`AGENTIC_CODING_BUILD_TOKEN` is being rendered in the ConfigMap template, but it
is secret-bearing and should not live in config data. Update the
`multiwoven-config.yaml` template so this value is removed from the ConfigMap
and instead wired through a Kubernetes Secret or secrets-store reference, and
adjust any related Helm values usage so the workload still reads it via the
secret-backed path. Use the `AGENTIC_CODING_BUILD_TOKEN` key in
`multiwoven-config.yaml` as the place to relocate this handling.
…_CODING_BUILD_TOKEN
Summary by CodeRabbit
New Features
Chores
0.97.0.