fix(box): grant box-controller update/patch on services for deploy cutover#140
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Helm chart version and appVersion were bumped to ChangesService-selector cutover
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
…tover The box-controller ClusterRole grants services [get,list,create,delete] but the deploy Service-selector cutover (SetServiceSelector) issues a PATCH/UPDATE on the box-deploy-svc-* Service. Without update/patch it's forbidden, so on a REDEPLOY the Service selector never moves to the new release-id -> the published app keeps serving the old release (or 404s), and the box logs "failed to cut Service over to new release ... forbidden" on every deploy. (#137 added update/patch for apps/deployments but missed services.) Adds update,patch to the services rule; bumps chart 0.95.1 -> 0.96.0. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
b556669 to
56aae78
Compare
…-services-rbac # Conflicts: # charts/multiwoven/Chart.yaml
hassimnaseef
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The box-controller ClusterRole (
templates/box-rbac.yaml) grantsservices: [get, list, create, delete], but the deploy Service-selector cutover (SetServiceSelector) issues an UPDATE/PATCH onbox-deploy-svc-<app>. Withoutupdate/patchit's forbidden, so on a redeploy the Service selector never moves to the new release-id → the published app keeps serving the old release (or 404s). The box logs this on every deploy:(#137 added
update/patchforapps/deploymentsbut missedservices.)Fix
Add
update,patchto theservicesrule. Chart0.95.1→0.95.2.Verified live
Reproduced on self-hosted: first deploy serves (Service is created with the right selector), but the cutover UPDATE is denied — confirmed via the box deploy logs above.
🤖 Generated with Claude Code
Summary by CodeRabbit
0.97.0to0.98.0.